Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extend rspec_helper with to use rspec-puppet-facts #23

Closed
igalic opened this issue Oct 14, 2015 · 4 comments
Closed

extend rspec_helper with to use rspec-puppet-facts #23

igalic opened this issue Oct 14, 2015 · 4 comments

Comments

@igalic
Copy link
Contributor

igalic commented Oct 14, 2015

our spec/spec_helper.rb should require 'rspec-puppet-facts', and 'include RspecPuppetFacts`
@igalic
Copy link
Contributor Author

igalic commented Oct 14, 2015

… and then we should start using it in our spec tests :)

@electrical
Copy link

Just a word of warning of my own experience.
Ensure you only loop tests that are actually platform dependent.
I overlooked that fact initially and caused a horrible explosion of tests and runtime.

As an example after refactoring the runtime of a single file went from 10 minutes to 30 seconds :-)

@igalic
Copy link
Contributor Author

igalic commented Oct 14, 2015

whoa…
thanks :D

@jyaworski
Copy link
Member

This was done at some point. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@electrical @jyaworski @igalic