Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json-schema unmaintained and fails to build on ruby 2.7 #105

Closed
lelutin opened this issue Feb 10, 2020 · 3 comments
Closed

json-schema unmaintained and fails to build on ruby 2.7 #105

lelutin opened this issue Feb 10, 2020 · 3 comments

Comments

@lelutin
Copy link

lelutin commented Feb 10, 2020

Hello,

I'm currently working on getting pdk (and thus metadata-json-lint too as a dependency) packaged for debian. I was told that during the just-finished dev sprint of the debian ruby team (working on transitioning debian testing to ruby 2.7), it was found that the json-schema library fails to build from source with ruby 2.7

Info about the failure can be found here:

https://people.debian.org/~kanashiro/ruby2.7/builds/7/ruby-json-schema/ruby-json-schema_2.8.1-1+rebuild1580878603_amd64-2020-02-05T04:56:44Z.build.txt

it was brought to my attention that the json-schema library has been unmaintained for a while now. this upstream ticket about trying to find new maintainers mentions some alternative libraries that can be used instead:

voxpupuli/json-schema#423

So, for the future maintainability of metadata-json-lint, it might be worthwhile to consider switching this library for another one offering similar functionality.

I've already reported the same issue with PDK which also directly depends on json-schema, and upstream told me that the dependency to the json-schema library will be removed in pdk 2.0.0

puppetlabs/pdk#848

Cheers!

@bastelfreak
Copy link
Member

Hi @lelutin. I also try to package pdk, but for Arch and I'm running into the same issue. The fix from voxpupuli/json-schema#437 works for me on ruby 2.7. However, switching to the other library mentioned in voxpupuli/json-schema#423 would be nice. Sadly I don't have the time at the moment to invest more time into metadata-json-lint :(

@lelutin
Copy link
Author

lelutin commented Feb 13, 2020

@bastelfreak thanks for the hint! we'll try applying the patch to the debian json-schema package to see if it avoids the issue with 2.7.
it's a generally better idea to switch to something that's maintained, but if it can give us a bit more time before doing the switch then maybe we can still have things that depend on json-schema working for a while. 👍

@ekohl
Copy link
Member

ekohl commented Nov 17, 2022

Closing this since the issues should be filed in https://github.com/voxpupuli/json-schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants