Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update internal substrait version to 0.24.0 #247

Merged
merged 4 commits into from
Feb 24, 2023

Conversation

thisisnic
Copy link
Contributor

@thisisnic thisisnic commented Feb 20, 2023

This PR updates the internal substrait version from 0.20.0 to 0.24.0

@thisisnic
Copy link
Contributor Author

thisisnic commented Feb 20, 2023

@paleolimbot I tried updating and running inst/update-substrait.R but I'm getting error messages starting with the following:

google/protobuf/any.proto:0:1:File not found.
substrait/extensions/extensions.proto:6:1:Import "google/protobuf/any.proto" was not found or had errors.
substrait/extensions/extensions.proto:77:3:"google.protobuf.Any" is not defined.
substrait/extensions/extensions.proto:80:3:"google.protobuf.Any" is not defined.
google/protobuf/empty.proto:0:1:File not found.
substrait/type.proto:6:1:Import "google/protobuf/empty.proto" was not found or had errors.
substrait/type.proto:192:7:"google.protobuf.Empty" is not defined.
substrait/algebra.proto:6:1:Import "google/protobuf/any.proto" was not found or had errors.
substrait/algebra.proto:7:1:Import "substrait/extensions/extensions.proto" was not found or had errors.

Have I missed a step here? Perhaps something to do with the code next to the comment "This is specific to a homebrew install"?

@thisisnic thisisnic marked this pull request as ready for review February 20, 2023 08:33
@thisisnic thisisnic force-pushed the update_substrait_version branch from df307f8 to 6f2cf96 Compare February 22, 2023 19:32
@thisisnic
Copy link
Contributor Author

@paleolimbot I can't get the update to update-substrait.R to work for me locally as the directory inst/substrait/proto/google doesn't exist yet

@paleolimbot
Copy link
Contributor

@thisisnic
Copy link
Contributor Author

I see https://github.com/voltrondata/substrait-r/tree/main/inst/substrait/proto/google/protobuf ?

My mistake, got mixed up with nested paths there.

Copy link
Contributor

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you!

@thisisnic thisisnic merged commit ff7fad1 into voltrondata:main Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants