Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: split aggregations with mixed scalar and aggregate functions #75

Merged
merged 7 commits into from
Aug 17, 2024
Merged

feat: split aggregations with mixed scalar and aggregate functions #75

merged 7 commits into from
Aug 17, 2024

Conversation

EpsilonPrime
Copy link
Contributor

By pushing scalar operations into project nodes aggregate measures can be
kept as aggregations.

@EpsilonPrime EpsilonPrime requested a review from richtia August 15, 2024 23:52
richtia
richtia approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@richtia richtia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks again for taking this!

Could we get those example in the docstrings for the ExpressionProcessingMode Enums?

@EpsilonPrime EpsilonPrime force-pushed the simpler_aggregate_relations branch from d3cf904 to 969b2bd Compare August 17, 2024 00:03
@EpsilonPrime EpsilonPrime merged commit 81f0304 into voltrondata:main Aug 17, 2024
17 checks passed
@EpsilonPrime EpsilonPrime deleted the simpler_aggregate_relations branch August 17, 2024 00:10
@EpsilonPrime EpsilonPrime mentioned this pull request Sep 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richtia richtia richtia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EpsilonPrime @richtia