Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add markers for datafusion TPCH test errors #14

Merged
merged 2 commits into from
May 21, 2024
+23 −1
Merged

fix: add markers for datafusion TPCH test errors #14

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67a8280
fix: document datafusion errors
richtia May 21, 2024
036270e
fix: revert commenting out tests
richtia May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion src/gateway/tests/test_tpch_with_dataframe_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,29 @@ def mark_tests_as_xfail(request):
request.node.add_marker(pytest.mark.xfail(reason='distinct not supported'))
elif source == 'gateway-over-datafusion':
pytest.importorskip("datafusion.substrait")
request.node.add_marker(pytest.mark.xfail(reason='gateway internal error'))
if originalname in ['test_query_01']:
request.node.add_marker(pytest.mark.xfail(reason='0-arg count not supported'))
elif originalname in ['test_query_03', 'test_query_10', 'test_query_20']:
request.node.add_marker(pytest.mark.xfail(reason='Schema mismatch'))
elif originalname in ['test_query_04']:
request.node.add_marker(pytest.mark.xfail(
reason='Aggregated function any_value is not supported'))
elif originalname in ['test_query_07']:
request.node.add_marker(pytest.mark.xfail(reason='Duplicate Expression names'))
elif originalname in ['test_query_09']:
request.node.add_marker(pytest.mark.xfail(
reason='Cannot create filter with non-boolean predicate - substr function'))
elif originalname in ['test_query_11']:
request.node.add_marker(pytest.mark.xfail(reason='Duplicate field in schema'))
elif originalname in ['test_query_14']:
request.node.add_marker(pytest.mark.xfail(reason='Sum not implemented'))
elif originalname in ['test_query_15', 'test_query_19', 'test_query_22']:
request.node.add_marker(pytest.mark.xfail(reason='no oneof "rex_type" field'))
elif originalname in ['test_query_18']:
request.node.add_marker(pytest.mark.xfail(
reason='Error with assigning date attribute during schema alignment'))
else:
request.node.add_marker(pytest.mark.xfail(reason='gateway internal error'))


class TestTpchWithDataFrameAPI:
Expand Down
Loading