Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add markers for datafusion TPCH test errors #14

Merged
merged 2 commits into from
May 21, 2024

Conversation

richtia
Copy link
Contributor

@richtia richtia commented May 21, 2024

No description provided.

Copy link

ACTION NEEDED

Substrait follows the Conventional Commits
specification
for
release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

@richtia richtia changed the title Document datafusion TPCH test errors fix: add markers for datafusion TPCH test errors May 21, 2024
Copy link
Contributor

@EpsilonPrime EpsilonPrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a number of these should be straightforward to fix. The rex_type missing is internal to the gateway, first is a reasonable replace for any, and I suspect we can find an alternative for the missing sum function.

@richtia richtia merged commit a0305cb into voltrondata:main May 21, 2024
9 of 11 checks passed
EpsilonPrime added a commit to EpsilonPrime/spark-substrait-gateway that referenced this pull request Aug 15, 2024
EpsilonPrime added a commit to EpsilonPrime/spark-substrait-gateway that referenced this pull request Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants