clean 'WG_BACKEND' unused code. #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhanluxianshen
force-pushed
the
clean-unused-code
branch
from
8b86204 to
3cca386
Compare
zhanluxianshen
changed the title
|
Yes, please delete the torchrpc part |
zhanluxianshen
force-pushed
the
clean-unused-code
branch
from
3cca386 to
7727312
Compare
zhanluxianshen
changed the title
Signed-off-by: zhanluxianshen <[email protected]>
zhanluxianshen
force-pushed
the
clean-unused-code
branch
from
7727312 to
6a10a8d
Compare
as12138
pushed a commit
to as12138/verl
that referenced
this pull request
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1 i see
WG_BACKENDwill == 'ray'2 i can not found the pkg about ' from verl.single_controller.torchrpc.k8s_client import get_ip_addr'
would these changes is ok for that?