vdk-control-cli: Adopt new auth exceptions #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doks5
force-pushed
the
person/andonova/vdk-auth
branch
from
3bdfa38 to
04120dd
Compare
gabrielgeorgiev1
approved these changes
May 30, 2022
After the introduction of new exception types in the `vdk-control-api-auth` plugin, more granular exception handling is now possible. This change adopts the new exception types in `vdk-control-cli`, and removes unnecessary error message parsing. Additionally, the exit status code when authentication failes was changed from 0 to 1 to better reflect the fact that something unexpected has happened. Testing Done: Unit tests Signed-off-by: Andon Andonov <[email protected]>
doks5
force-pushed
the
person/andonova/vdk-auth
branch
from
04120dd to
65e77ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the introduction of new exception types in the
vdk-control-api-authplugin, more granular exception handlingis now possible.
This change adopts the new exception types in
vdk-control-cli,and removes unnecessary error message parsing.
Additionally, the exit status code when authentication failes was
changed from 0 to 1 to better reflect the fact that something unexpected
has happened.
Testing Done: Unit tests
Signed-off-by: Andon Andonov [email protected]