vdk-core: fix buggy (false positive) connection unit test #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniivanov
force-pushed
the
person/aivanov/vdk-core-conn-test
branch
from
b4e0d03 to
b99d349
Compare
We have a unit test that checks the raw (or native) connection is being saved properly - but the test was buggy since they are qual in a sense they have the same attribute values (as there's only one "is_valid") . But we care if it's the same instance. So we switch to "is" Testing Done: After changing == to "is" ran the test and it failed (as it should) and then fix the test. Signed-off-by: Antoni Ivanov <[email protected]>
antoniivanov
force-pushed
the
person/aivanov/vdk-core-conn-test
branch
from
b99d349 to
870e074
Compare
|
The PR desc mentions fixing the test, but I only see replacement of |
No, this is the fix in the test. It was false positive (it was passing even though it should not have) because native_conn.eq(managed_conn) (native_conn == managed_conn. Instead using "is" operator now would return true only if both vars refer to the same object |
gabrielgeorgiev1
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a unit test that checks the raw (or native) connection is being
saved properly - but the test was buggy since they are qual in a sense
they have the same attribute values (as there's only one "is_valid") .
But we care if it's the same instance. So we switch to "is"
Testing Done: After changing == to "is" ran the test and it failed (as
it should) and then fix the test.
Signed-off-by: Antoni Ivanov [email protected]