vdk-core: replace report_and_rethrow #3056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeltaMichael
force-pushed
the
person/mdilyan/report-raise-core
branch
2 times, most recently
from
70bef08 to
4a7544b
Compare
Why? Calling report_and_rethrow causes confusing stack traces, because of adding an extra frame from the extra function call What? Replace report_and_rethrow with just calling report and raising the exception after How was this tested? CI What kind of change is this? Feature/non-breaking Signed-off-by: Dilyan Marinov <[email protected]>
DeltaMichael
force-pushed
the
person/mdilyan/report-raise-core
branch
from
4a7544b to
3e96fb5
Compare
antoniivanov
approved these changes
Jan 26, 2024
duyguHsnHsn
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Calling report_and_rethrow causes confusing stack traces, because of adding an extra frame from the extra function call
What?
Replace report_and_rethrow with just calling report and raising the exception after
How was this tested?
CI
What kind of change is this?
Feature/non-breaking