vdk-oracle: fixes in tests and passing secrets #3031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duyguHsnHsn
approved these changes
Jan 16, 2024
1. Fix the tests to be timezone independant. Currently they were failing because fromtimestamp is timezone dependant so it will return different reseult depending on the timezone 2. Simplify passing secrets as configuration by removing redudant configuration options and note it's just a prototype until such change is in core. It is unnecsary to pass 3 configuration options to start passing secret. Just read everytime secrets if there's one use if not no. Kept option "ORACLE_USE_SECRETS" as a kill switch just in case.
antoniivanov
force-pushed
the
person/aivanov/oracle
branch
from
2f459e5 to
ef69ad1
Compare
DeltaMichael
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the tests to be timezone independant. Currently they were failing because fromtimestamp is timezone dependant so it will return different reseult depending on the timezone
Simplify passing secrets as configuration by removing redudant configuration options and note it's just a prototype until such change is in core. It is unnecsary to pass 3 configuration options to start passing secret. Just read everytime secrets if there's one use if not no. Kept option "ORACLE_USE_SECRETS" as a kill switch just in case.