Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

control-service: reduce logging #2834

Merged
merged 1 commit into from
Oct 25, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ private static String serializeObject(Object obj) {
mapper.setSerializationInclusion(JsonInclude.Include.NON_NULL);
result = mapper.writeValueAsString(obj);
} catch (JsonProcessingException e) {
log.debug("Failed to convert object to json: {}: {}", obj.getClass(), e.getMessage());
log.trace("Failed to convert object to json: {}: {}", obj.getClass(), e.getMessage());
result = "" + obj;
}
return result;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public void sendAsync(String payload) {
if (StringUtils.isBlank(this.telemetryEndpoint)) {
return;
}
log.debug("Sending streaming telemetry to {}", telemetryEndpoint);
log.trace("Sending streaming telemetry to {}", telemetryEndpoint);
HttpResponse.BodyHandler<String> handler = HttpResponse.BodyHandlers.ofString();

HttpRequest request =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ protected boolean getK8sSupportsV1CronJob() {

private V1CronJob loadV1CronjobTemplate() {
if (StringUtils.isEmpty(datajobTemplateFileLocation)) {
log.debug("Datajob template file location is not set. Using internal datajob template.");
log.trace("Datajob template file location is not set. Using internal datajob template.");
return loadInternalV1CronjobTemplate();
}
V1CronJob cronjobTemplate = loadConfigurableV1CronjobTemplate();
Expand All @@ -240,7 +240,7 @@ private V1CronJob loadV1CronjobTemplate() {

private V1beta1CronJob loadV1beta1CronjobTemplate() {
if (StringUtils.isEmpty(datajobTemplateFileLocation)) {
log.debug("Datajob template file location is not set. Using internal datajob template.");
log.trace("Datajob template file location is not set. Using internal datajob template.");
return loadInternalV1beta1CronjobTemplate();
}
V1beta1CronJob cronjobTemplate = loadConfigurableV1beta1CronjobTemplate();
Expand Down Expand Up @@ -278,7 +278,7 @@ private V1CronJob loadInternalV1CronjobTemplate() {
private V1beta1CronJob loadConfigurableV1beta1CronjobTemplate() {
// Check whether to use configurable datajob template at all.
if (StringUtils.isEmpty(datajobTemplateFileLocation)) {
log.debug("Datajob template file location is not set.");
log.trace("Datajob template file location is not set.");
return null;
}

Expand All @@ -295,7 +295,7 @@ private V1beta1CronJob loadConfigurableV1beta1CronjobTemplate() {
private V1CronJob loadConfigurableV1CronjobTemplate() {
// Check whether to use configurable datajob template at all.
if (StringUtils.isEmpty(datajobTemplateFileLocation)) {
log.debug("Datajob template file location is not set.");
log.trace("Datajob template file location is not set.");
return null;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ public void updateDeployment(

if (DeploymentStatus.USER_ERROR.equals(desiredJobDeployment.getStatus())
|| DeploymentStatus.PLATFORM_ERROR.equals(desiredJobDeployment.getStatus())) {
log.debug(
log.trace(
"Skipping the data job [job_name={}] deployment due to the previously failed deployment"
+ " [status={}]",
dataJob.getName(),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ public Set<String> listCronJobs() throws ApiException {
v1BetaCronJobs.getItems().stream()
.map(j -> j.getMetadata().getName())
.collect(Collectors.toSet());
log.debug("K8s V1Beta cron jobs: {}", v1BetaCronJobNames);
log.trace("K8s V1Beta cron jobs: {}", v1BetaCronJobNames);
return Stream.concat(v1CronJobNames.stream(), v1BetaCronJobNames.stream())
.collect(Collectors.toSet());
}
Expand Down