Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

control-service: improve async deployment logging #2826

Merged
merged 1 commit into from
Oct 24, 2023
Merged

control-service: improve async deployment logging #2826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,11 @@ repos:
args: # http://www.pydocstyle.org/en/stable/error_codes.html --convention=pep257 seems too much?
- --select=D101,D103,D300
- --match='(?!test_).*\.py'
- repo: https://github.com/pre-commit/mirrors-pylint
rev: 'v3.0.0a5'
hooks:
- id: pylint
args: [ --exit-zero ]
#- repo: https://github.com/pre-commit/mirrors-pylint
# rev: 'v3.0.0a5'
# hooks:
# - id: pylint
# args: [ --exit-zero ]
#- repo: https://github.com/pre-commit/mirrors-mypy
# rev: v0.812
# hooks:
Expand Down
1 change: 1 addition & 0 deletions ...s_control_service/src/main/java/com/vmware/taurus/service/deploy/DeploymentServiceV2.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ public void updateDeployment(
boolean sendNotification = Boolean.TRUE.equals(desiredJobDeployment.getUserInitiated());

try {
log.trace("Starting deployment of job {}", desiredJobDeployment.getDataJobName());
deploymentProgress.started(dataJob.getJobConfig(), desiredJobDeployment);

if (desiredJobDeployment.getPythonVersion() == null) {
Expand Down
6 changes: 3 additions & 3 deletions ...lines_control_service/src/main/java/com/vmware/taurus/service/deploy/JobImageBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,10 +134,10 @@ public boolean buildImage(
String builderAwsSessionToken = credentials.awsSessionToken();
String awsRegion = credentials.region();

log.info("Build data job image for job {}. Image name: {}", dataJob.getName(), imageName);
log.trace("Build data job image for job {}. Image name: {}", dataJob.getName(), imageName);
if (!StringUtils.isBlank(registryType)) {
if (unsupportedRegistryType(registryType)) {
log.debug(
log.warn(
String.format(
"Unsupported registry type: %s available options %s/%s",
registryType, REGISTRY_TYPE_ECR, REGISTRY_TYPE_GENERIC));
Expand All @@ -151,7 +151,7 @@ public boolean buildImage(
}

if (dockerRegistryService.dataJobImageExists(imageName, credentials)) {
log.debug("Data Job image {} already exists and nothing else to do.", imageName);
log.trace("Data Job image {} already exists and nothing else to do.", imageName);
return true;
}

Expand Down
1 change: 1 addition & 0 deletions ...es_control_service/src/main/java/com/vmware/taurus/service/deploy/JobImageDeployerV2.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ public ActualDataJobDeployment scheduleJob(
String jobImageName) {
Validate.notNull(desiredDataJobDeployment, "desiredDataJobDeployment should not be null");
Validate.notNull(jobImageName, "Image name is expected in jobDeployment");
log.trace("Update cron job for data job {}", dataJob.getName());

try {
return updateCronJob(
Expand Down