vdk-impala: add Out Of Memory error handling

[dakodakov]

Add Out Of Memory error handling logic in the vdk-impala error handler.

[antoniivanov]

Looks good to me! My comments are mostly "clean code" type of comments.

[antoniivanov]

I am wondering if we want to write a functional test that simulates out of memory query. That might not be easy.

Regardless you should test it against real system and describe how you test it in Testing Done in the PR.
(hint: you probably know but you can install it in your existing prod or test vdk env with pip install -e <vdk-impal-dir>)

[dakodakov]

I am wondering if we want to write a functional test that simulates out of memory query. That might not be easy.

Regardless you should test it against real system and describe how you test it in Testing Done in the PR. (hint: you probably know but you can install it in your existing prod or test vdk env with pip install -e <vdk-impal-dir>)

I tested these changes on our testing impala instance together with our Infra team and the logic for this change is the result of our testing and research we did around these issues and the Impala memory configuration and settings.

[antoniivanov]

Thanks. Looks good to me.

[antoniivanov]

I tested these changes on our testing impala instance together with our Infra team and the logic for this change is the result of our testing and research we did around these issues and the Impala memory configuration and settings.

That was a bit unspecific. When something is tested manually, it's really good idea to describe it in a way that make the test reproducible by someone else. This way it can be peer-reviewed as well better.

For example. What is the configuration of the testing Impala instance used, what types of queries were executed, what specific memory and performance metrics were tracked and used for verification. In general you can summarize the research that led to the logic implemented for handling memory issues.