From 0fdf3fbde007f94963f58d28634c7445830ec7a7 Mon Sep 17 00:00:00 2001 From: gageorgiev Date: Tue, 21 Sep 2021 13:43:34 +0300 Subject: [PATCH] vdk-core: Remove databases from DB_DEFAULT_TYPE description The DB_DEFAULT_TYPE env variable description previously had a section which would in the future list the database connectors available through plugins, which was currently labeled TODO. However, since the ManagedConnectionRouter, which is where the list of connectors is stored, is part of the JobContext, and the DB_DEFAULT_TYPE description is set through a vdk_configure call, there is no simple way of capturing and display the list. For this reason, the change removes the section from the description for the mean time, but keeps the TODO code comment. Testing done: pipelines passed Signed-off-by: gageorgiev --- .../src/vdk/internal/builtin_plugins/config/vdk_config.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/projects/vdk-core/src/vdk/internal/builtin_plugins/config/vdk_config.py b/projects/vdk-core/src/vdk/internal/builtin_plugins/config/vdk_config.py index 980494ccad..25a787fc9a 100644 --- a/projects/vdk-core/src/vdk/internal/builtin_plugins/config/vdk_config.py +++ b/projects/vdk-core/src/vdk/internal/builtin_plugins/config/vdk_config.py @@ -47,8 +47,7 @@ def vdk_configure(self, config_builder: ConfigurationBuilder) -> None: db_default_type_description = ( "Default DB connection provided by VDK when executing a data job. " "All sql queries, templates/loads would be against that database." - "Different database types can be configured with plugins. " - "Current supported database types: TODO \n" + "Different database types can be configured with plugins. \n" ) config_builder.add(DB_DEFAULT_TYPE, None, True, db_default_type_description)