vdk-dag: fix failing validation tests #2712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeltaMichael
force-pushed
the
person/mdilyan/vdk-dag-tests-fix
branch
2 times, most recently
from
bcd6052 to
3d00d4e
Compare
Why? Tests started failing after #2666 Most likely due to not wrapping errors in UserCodeError anymore What? Pass the dag name to the dag validation test fixture Expect just one request in the dag, as we do a GET request to fetch the job info before doing validation How was this tested? Ran test suite locally What kind of change is this? Bugfix Signed-off-by: Dilyan Marinov <[email protected]>
DeltaMichael
force-pushed
the
person/mdilyan/vdk-dag-tests-fix
branch
from
3d00d4e to
c8e353a
Compare
duyguHsnHsn
approved these changes
Sep 28, 2023
antoniivanov
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Tests started failing after #2666 Most likely due to not wrapping errors in UserCodeError anymore
What?
Pass the dag name to the dag validation test fixture
Expect just one request in the dag, as we do a GET request to fetch the job info before doing validation
How was this tested?
Ran test suite locally
What kind of change is this?
Bugfix