Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdk-dag, vdk-control-cli, airflow-provider-vdk: step using deprecated field #2706

Merged
merged 3 commits into from
Sep 28, 2023

Conversation

antoniivanov
Copy link
Collaborator

@antoniivanov antoniivanov commented Sep 26, 2023

cache_locally was deprecated in favour of credentials_cache

Since the credentials_cache default is LocalFolderCredentialsCache we can leave the default

This is really 3 changes in single PR - but the change would be merged in 3 separate commits for each plugin

Testing Done: existing tests passed, showing no regression

Copy link
Contributor

@doks5 doks5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can add a note to the description how was this change tested?

cache_locally was deprecatd in favour of credentials_cache

Since credentials_cache default is LocalFolderCredentialsCache we can
leave the default
cache_locally was deprecatd in favour of credentials_cache

Since credentials_cache default is LocalFolderCredentialsCache we can
leave the default

Signed-off-by: Antoni Ivanov <[email protected]>
    cache_locally was deprecatd in favour of credentials_cache

    Since credentials_cache default is LocalFolderCredentialsCache we can
    leave the default

    Signed-off-by: Antoni Ivanov <[email protected]>
@antoniivanov antoniivanov merged commit 96bb985 into main Sep 28, 2023
@antoniivanov antoniivanov deleted the person/aivanov/auth branch September 28, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants