vdk-jupyter: fix arguments input size #2685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabadzhiev
approved these changes
Sep 21, 2023
antoniivanov
approved these changes
Sep 21, 2023
antoniivanov
deleted the
person/hduygu/vdk-jupyter-fix-arguments-input-size
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Refined RunJobDialog and VDKTextInput components. Ensured the arguments input uses VDKTextInput and streamlined RunJobDialog state management.
Why:
The old approach had sizing inconsistencies between the arguments and path inputs. Converting arguments input to VDKTextInput clears its association with VDK data, enhancing visibility and cohesion. Additionally, removing the unnecessary inputWidth state from RunJobDialog makes the code leaner and more manageable.
Signed-off-by: Duygu Hasan [email protected]