vdk-jupyter: change Create and Download default path #2669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniivanov
approved these changes
Sep 18, 2023
sabadzhiev
approved these changes
Sep 19, 2023
…h-for-create-and-download
duyguHsnHsn
deleted the
person/hduygu/vdk-jupyter-change-default-path-for-create-and-download
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Updated "Create" and "Download" functionalities to default to the Jupyter root directory.
And also added tool tip that gives more information about the input itself. The information only shows up when we hover the question mark element next to the input label.
Why: Initial implementations utilised the current working Jupyter directory. However, usability tests indicated that this approach was causing confusion. To enhance user experience, the default has been changed to the root directory.
Signed-off-by: Duygu Hasan [email protected]