-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
control-service: add amazon rds ca certificates to data job image #2660
Conversation
Signed-off-by: mrMoZ1 <[email protected]>
not sure I understand this change, if users need a particular certificate, is it not their responsibility to include it as part of their job or download it? |
Job users can't download or add anything in the secure images except for the tmp folders. |
projects/control-service/projects/job-builder-secure/Dockerfile.python.vdk
Outdated
Show resolved
Hide resolved
Signed-off-by: mrMoZ1 <[email protected]>
projects/control-service/projects/job-base-image-secure/Dockerfile-data-job-base
Outdated
Show resolved
Hide resolved
That's not 100% true. A) They can download it to temp directory and then point REQUESTS_CA_BUNDLE (if they use requests library) or SSL_CERT_DIR (for openssl) to that location. Now they need to do that every execution and it's not very nice and good user experience. B) user should install C) Similarly to certifi if user can install aws-certifi (there is not such but could be created). I would definitely want to know if |
In order to speed up the process can you assist us with this matter? A customer is currently facing a blockage related to it. |
Signed-off-by: mrMoZ1 <[email protected]>
I've approved it. But advice the user the try adding |
The customer tried a few things to get this to work - one of them was installing the certifi library. Here is what the customer tried on their own and it didn't work: I can’t seem to get this working. The file system is read only and certificates are not an allowed file type that I can add to the data job. Even saving the certificate as a .txt the file gets recognized as a cert. I even tried adding the certificate as a variable in python and creating an in memory file and it wouldn’t work. Either we need to allow certificate files or I need these in the container already. |
what:
Adding amazon rds ca certificates to secure job image
why:
Data job users require ca certificates to connect to amazon databases
testing:
building images locally and inspecting certificate output:
List truncated because of 100+ certificates
`38.45 subject=C = US, O = "Amazon Web Services, Inc.", OU = Amazon RDS, ST = WA, CN = Amazon RDS eu-west-1 Root CA RSA4096 G1, L = Seattle
38.46 subject=C = US, O = "Amazon Web Services, Inc.", OU = Amazon RDS, ST = WA, CN = Amazon RDS eu-central-1 Root CA RSA4096 G1, L = Seattle
38.46 subject=C = US, O = "Amazon Web Services, Inc.", OU = Amazon RDS, ST = WA, CN = Amazon RDS eu-north-1 Root CA RSA2048 G1, L = Seattle
`