control-service: move cron jobs methods to the data jobs class #2291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: murphp15 <[email protected]>
gabrielgeorgiev1
approved these changes
Jun 21, 2023
antoniivanov
approved these changes
Jun 21, 2023
Correct! |
murphp15
deleted the
person/murphp15/move_cron_job_methods_to_data_jobs_class
branch
mivanov1988
pushed a commit
that referenced
this pull request
Jun 21, 2023
# Why At the moment the KubernetesService class as much to much responsibilities. It is extended by DataJobsKubernetesService and controlKubernetesService class. However it includes the logic that is unique to those individual classes also. For example only the datajobsKS creates or deploys cron jobs. So in this PR I move those external facing functions to the dataJobsclass and fix the tests. I have not move alot of the more private functions to the datajobs class yet because alot of other tests need to be changed to achieve this as they are being tested using reflection and I want to keep the PRs small. # How has this been tested? Locally. Signed-off-by: murphp15 <[email protected]> --------- Co-authored-by: github-actions <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
At the moment the KubernetesService class as much to much responsibilities.
It is extended by DataJobsKubernetesService and controlKubernetesService class.
However it includes the logic that is unique to those individual classes also.
For example only the datajobsKS creates or deploys cron jobs.
So in this PR I move those external facing functions to the dataJobsclass and fix the tests.
I have not move alot of the more private functions to the datajobs class yet because alot of other tests need to be changed to achieve this as they are being tested using reflection and I want to keep the PRs small.
How has this been tested?
Locally.
Signed-off-by: murphp15 [email protected]