Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

control-service: remove unused properties #2262

Merged
merged 2 commits into from
Jun 15, 2023
Merged

control-service: remove unused properties #2262

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c067be8
control-service: remove unused properties
murphp15 Jun 15, 2023
61b7dc8
Google Java Format
Jun 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .../pipelines_control_service/src/main/java/com/vmware/taurus/service/KubernetesService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@
import java.util.stream.Collectors;
import java.util.stream.Stream;


/**
* A facade over Kubernetes (https://en.wikipedia.org/wiki/Facade_pattern) (not complete see
* JobImageDeployer)
Expand Down Expand Up @@ -176,21 +175,17 @@ private enum ContainerResourceType {
private int jobTTLAfterFinishedSeconds;

private String namespace;
private String kubeconfig;
private Logger log;
private final ApiClient client;
private final BatchV1Api batchV1Api;
private final BatchV1beta1Api batchV1beta1Api;
private boolean k8sSupportsV1CronJob;

@Autowired private UserAgentService userAgentService;

@Autowired private final JobCommandProvider jobCommandProvider;

/**
* @param namespace the namespace where the kubernetes operation will act on. leave empty to infer
* from kubeconfig
* @param kubeconfig The kubeconfig configuration of the Kubernetes cluster to connect to
* @param k8sSupportsV1CronJob Whether the target K8s cluster supports the V1CronJob API
* @param log log to use - used in subclasses in order to set classname to subclass.
*/
Expand Down