Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdk-jupyter: fix build by pinning every package to a specific version #2186

Merged
merged 7 commits into from
Jun 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,17 @@ for the frontend extension.
- JupyterLab >= 3.0
- python ~=3.7
- Versatile Data Kit
- npm

## Install

To install the extension, execute:
To install the extension,first navigate to the project directory and then execute:

```bash
# Once in the project directory, use the npm ci command to install
# the exact versions of the dependencies specified in the package-lock.json
npm ci
# Install the extension
pip install vdk-jupyterlab-extension
```

Expand Down Expand Up @@ -58,6 +63,9 @@ The `jlpm` command is JupyterLab's pinned version of
```bash
# Clone the repo to your local environment
# Change directory to the vdk-jupyterlab-extension directory
# Once in the project directory, use the npm ci command to install
# the exact versions of the dependencies specified in the package-lock.json
npm ci
# Install package in development mode
pip install -e .
# Link your development version of the extension with JupyterLab
Expand All @@ -68,6 +76,9 @@ jupyter server extension enable vdk-jupyterlab-extension
jlpm build
```

NB: If you're changing some dependencies of the project,
meaning you're adding, removing, or updating packages, you'd use npm install.

You can watch the source directory and run JupyterLab at the same time in different terminals to watch for changes in the extension's source and automatically rebuild the extension.

```bash
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ module.exports = {
testPathIgnorePatterns,
transform,
automock: false,
testEnvironment: 'jsdom',
collectCoverageFrom: [
'src/**/*.{ts,tsx}',
'!src/**/*.d.ts',
Expand Down
Loading