Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vdk-jupyter: small fixtures on the ui #2161

Merged
merged 6 commits into from
Jun 8, 2023
Merged

vdk-jupyter: small fixtures on the ui #2161

merged 6 commits into from
Jun 8, 2023

Conversation

duyguHsnHsn
Copy link
Collaborator

With the current UI we had some problems in term of accessibility and design:

  • the placeholder text in vdk inputs for job path was too much and could not be read
  • the create job dialog was not aligned well (caused be typo in classname)
    See:
Screenshot 2023-05-30 at 18 36 05 Screenshot 2023-05-30 at 18 36 22

The changes introduced:

  • the job path input placeholder shows only the parent directory:
Screenshot 2023-05-30 at 18 37 14
  • and create job items are aligned better
Screenshot 2023-05-30 at 18 38 06

Signed-off-by: Duygu Hasan [email protected]

@duyguHsnHsn duyguHsnHsn enabled auto-merge (squash) June 8, 2023 12:15
@duyguHsnHsn duyguHsnHsn merged commit ea407ba into main Jun 8, 2023
@duyguHsnHsn duyguHsnHsn deleted the person/hduygu/jupyter-ui-small-fixtures branch June 8, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivakoleva ivakoleva ivakoleva approved these changes

@yonitoo yonitoo yonitoo approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@duyguHsnHsn @ivakoleva @yonitoo @vmwclabot