diff --git a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/__tests__/create-job-component.spec.ts b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/__tests__/create-job-component.spec.ts index efd484f685..3f1098c116 100644 --- a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/__tests__/create-job-component.spec.ts +++ b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/__tests__/create-job-component.spec.ts @@ -82,15 +82,6 @@ describe('#onTeamChange', () => { }); }); -describe('#onRestApiUrlChange', () => { - it('should change the rest api url in jobData', () => { - const component = render(new CreateJobDialog(defaultProps).render()); - const input = component.getByPlaceholderText('http://my_vdk_instance'); - fireEvent.change(input, { target: { value: 'random-url' } }); - expect(jobData.get(VdkOption.REST_API_URL)).toEqual('random-url'); - }); -}); - describe('#onPathChange', () => { it('should change the path in jobData', () => { const component = render(new CreateJobDialog(defaultProps).render()); diff --git a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/__tests__/delete-job-component.spec.ts b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/__tests__/delete-job-component.spec.ts index 9104b6cddc..aa7e7b1999 100644 --- a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/__tests__/delete-job-component.spec.ts +++ b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/__tests__/delete-job-component.spec.ts @@ -46,12 +46,3 @@ describe('#onTeamChange', () => { expect(jobData.get(VdkOption.TEAM)).toEqual('second-team'); }); }); - -describe('#onRestApiUrlChange', () => { - it('should change the rest api url in jobData', () => { - const component = render(new DeleteJobDialog(defaultProps).render()); - const input = component.getByPlaceholderText('http://my_vdk_instance'); - fireEvent.change(input, { target: { value: 'random-url' } }); - expect(jobData.get(VdkOption.REST_API_URL)).toEqual('random-url'); - }); -}); diff --git a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/__tests__/deploy-job-component.spec.ts b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/__tests__/deploy-job-component.spec.ts index a1821138f2..b38e76734e 100644 --- a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/__tests__/deploy-job-component.spec.ts +++ b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/__tests__/deploy-job-component.spec.ts @@ -69,15 +69,6 @@ describe('#onTeamChange', () => { }); }); -describe('#onRestApiUrlChange', () => { - it('should change the rest api url in jobData', () => { - const component = render(new DeployJobDialog(defaultProps).render()); - const input = component.getByPlaceholderText('http://my_vdk_instance'); - fireEvent.change(input, { target: { value: 'random-url' } }); - expect(jobData.get(VdkOption.REST_API_URL)).toEqual('random-url'); - }); -}); - describe('#onPathChange', () => { it('should change the path in jobData', () => { const component = render(new DeployJobDialog(defaultProps).render()); diff --git a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/__tests__/download-job-component.spec.ts b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/__tests__/download-job-component.spec.ts index b4667c661f..f578f0af43 100644 --- a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/__tests__/download-job-component.spec.ts +++ b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/__tests__/download-job-component.spec.ts @@ -54,15 +54,6 @@ describe('#onTeamChange', () => { }); }); -describe('#onRestApiUrlChange', () => { - it('should change the rest api url in jobData', () => { - const component = render(new DownloadJobDialog(defaultProps).render()); - const input = component.getByPlaceholderText('http://my_vdk_instance'); - fireEvent.change(input, { target: { value: 'random-url' } }); - expect(jobData.get(VdkOption.REST_API_URL)).toEqual('random-url'); - }); -}); - describe('#onPathChange', () => { it('should change the path in jobData', () => { const component = render(new DownloadJobDialog(defaultProps).render()); diff --git a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/components/CreateJob.tsx b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/components/CreateJob.tsx index ab6354ce41..80096d1df9 100644 --- a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/components/CreateJob.tsx +++ b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/components/CreateJob.tsx @@ -61,11 +61,6 @@ export default class CreateJobDialog extends Component<(IJobFullProps)> { value={this.props.jobTeam} label="Job Team:" > - { */ private _onLocalClick() { return (event: React.MouseEvent) => { - this.setJobFlags('Local', 'jobPath'); + this.setJobFlags('Local'); }; } /** @@ -87,18 +82,16 @@ export default class CreateJobDialog extends Component<(IJobFullProps)> { */ private _onCloudClick() { return (event: React.MouseEvent) => { - this.setJobFlags('Cloud', 'jobRestApiUrl'); + this.setJobFlags('Cloud'); }; } /** * Function that sets job's cloud/local flags */ - private setJobFlags(flag: string, inputId: string) { + private setJobFlags(flag: string) { let checkbox = document.getElementById(flag); - let input = document.getElementById(inputId); if (checkbox?.classList.contains('checked')) { checkbox.classList.remove('checked'); - input?.parentElement?.classList.add('hidden'); if (flag === 'Cloud') { jobData.set(VdkOption.CLOUD, ''); } else { @@ -111,7 +104,6 @@ export default class CreateJobDialog extends Component<(IJobFullProps)> { } else { jobData.set(VdkOption.LOCAL, '1'); } - input?.parentElement?.classList.remove('hidden'); } } } diff --git a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/components/DeleteJob.tsx b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/components/DeleteJob.tsx index 739b88fd05..e1645f2c99 100644 --- a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/components/DeleteJob.tsx +++ b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/components/DeleteJob.tsx @@ -35,11 +35,6 @@ export default class DeleteJobDialog extends Component { value={this.props.jobTeam} label="Job Team:" > - ); } @@ -63,8 +58,6 @@ export async function showDeleteJobDialog() { body: 'Do you really want to delete the job with name ' + jobData.get(VdkOption.NAME) + - ' from ' + - jobData.get(VdkOption.REST_API_URL) + '?', buttons: [ Dialog.cancelButton({ label: 'Cancel' }), diff --git a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/components/DeployJob.tsx b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/components/DeployJob.tsx index 78a25a627d..dbe32d9303 100644 --- a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/components/DeployJob.tsx +++ b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/components/DeployJob.tsx @@ -35,11 +35,6 @@ export default class DeployJobDialog extends Component<(IJobFullProps)> { value={this.props.jobTeam} label="Job Team:" > - { value="default-team" label="Job Team:" > -