Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: Implement executions list enhacements #2126

Merged

Conversation

gorankokin
Copy link
Contributor

Executions list highlighting is in sync with duration chart focus on event (execution).
Change label text on filter by period.
Added caret next to text from time period filter.
Implement synchronization between time period filter, duration zoom, grid filters and grid sort criteria. Whenever change occurs it is reflected on the other components/charts and everything is sharable through URL.

@gorankokin gorankokin added the area/frontend Related to changes in the folder projects/frontend for details about ui please see readme label May 24, 2023
@gorankokin gorankokin self-assigned this May 24, 2023
@gorankokin gorankokin requested a review from hzhristova as a code owner May 24, 2023 23:44
@gorankokin gorankokin force-pushed the person/gorankokin/improve-data-job-executions-chart-zoom branch from 099ef3a to 7f32fa0 Compare May 25, 2023 11:57
@gorankokin gorankokin force-pushed the person/gorankokin/improve-data-job-executions-chart-zoom branch 3 times, most recently from dda244a to ff2b724 Compare May 26, 2023 09:13
@gorankokin gorankokin force-pushed the person/gorankokin/improve-data-job-executions-chart-zoom branch from ff2b724 to cc3d46e Compare May 26, 2023 11:47
@antoniivanov
Copy link
Collaborator

Please provide screenshots.

@gorankokin gorankokin force-pushed the person/gorankokin/improve-data-job-executions-chart-zoom branch 2 times, most recently from 6763e14 to c409564 Compare May 30, 2023 13:53
Executions list highlighting is in sync with duration
chart focus on event (execution).
Change label text on filter by period.
Added caret next to text from time period filter.
Implement synchronization between time period filter,
duration zoom, grid filters and grid sort criteria.
Whenever change occurs it is reflected on the other
components/charts and everything is sharable through URL.

Signed-off-by: Goran Kokinovski <[email protected]>
Fix for Cypress e2e tests to correctly assert table values

Signed-off-by: Goran Kokinovski <[email protected]>
@gorankokin gorankokin force-pushed the person/gorankokin/improve-data-job-executions-chart-zoom branch from be033a6 to 790618a Compare May 30, 2023 13:56
@gorankokin
Copy link
Contributor Author

Screenshot 2023-05-30 at 16 12 50 Screenshot 2023-05-30 at 16 13 04 Screenshot 2023-05-30 at 16 13 55

Fix for Manage and Explore Data Jobs list to correctly
apply sorting together withs filters and as standalone.

Signed-off-by: Goran Kokinovski <[email protected]>
@gorankokin gorankokin force-pushed the person/gorankokin/improve-data-job-executions-chart-zoom branch from 790618a to 7ca54e7 Compare May 30, 2023 14:52
Copy link
Collaborator

@antoniivanov antoniivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the screenshots. Looks good to me. I think these improvements would make the UI more intuitive and easier to navigate for our user users.

@gorankokin gorankokin merged commit 52eb317 into main May 30, 2023
@gorankokin gorankokin deleted the person/gorankokin/improve-data-job-executions-chart-zoom branch May 30, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to changes in the folder projects/frontend for details about ui please see readme cla-not-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants