-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend: Implement executions list enhacements #2126
Merged
gorankokin
merged 3 commits into
main
from
person/gorankokin/improve-data-job-executions-chart-zoom
May 30, 2023
Merged
frontend: Implement executions list enhacements #2126
gorankokin
merged 3 commits into
main
from
person/gorankokin/improve-data-job-executions-chart-zoom
May 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
099ef3a
to
7f32fa0
Compare
hzhristova
approved these changes
May 25, 2023
dda244a
to
ff2b724
Compare
VladimirPetkov1
approved these changes
May 26, 2023
ff2b724
to
cc3d46e
Compare
Please provide screenshots. |
6763e14
to
c409564
Compare
Executions list highlighting is in sync with duration chart focus on event (execution). Change label text on filter by period. Added caret next to text from time period filter. Implement synchronization between time period filter, duration zoom, grid filters and grid sort criteria. Whenever change occurs it is reflected on the other components/charts and everything is sharable through URL. Signed-off-by: Goran Kokinovski <[email protected]>
Fix for Cypress e2e tests to correctly assert table values Signed-off-by: Goran Kokinovski <[email protected]>
be033a6
to
790618a
Compare
Fix for Manage and Explore Data Jobs list to correctly apply sorting together withs filters and as standalone. Signed-off-by: Goran Kokinovski <[email protected]>
790618a
to
7ca54e7
Compare
antoniivanov
approved these changes
May 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the screenshots. Looks good to me. I think these improvements would make the UI more intuitive and easier to navigate for our user users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/frontend
Related to changes in the folder projects/frontend for details about ui please see readme
cla-not-required
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Executions list highlighting is in sync with duration chart focus on event (execution).
Change label text on filter by period.
Added caret next to text from time period filter.
Implement synchronization between time period filter, duration zoom, grid filters and grid sort criteria. Whenever change occurs it is reflected on the other components/charts and everything is sharable through URL.