-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend: ping frontend on docker image release #2101
Merged
DeltaMichael
merged 1 commit into
main
from
person/mdilyan/ping-frontend-on-image-deploy
Jun 9, 2023
Merged
frontend: ping frontend on docker image release #2101
DeltaMichael
merged 1 commit into
main
from
person/mdilyan/ping-frontend-on-image-deploy
Jun 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivakoleva
reviewed
May 22, 2023
06ab1ea
to
e6eabb3
Compare
murphp15
approved these changes
May 22, 2023
563b8ac
to
e9b14fe
Compare
e9b14fe
to
2da5375
Compare
ivakoleva
reviewed
Jun 1, 2023
771cba3
to
240f2cd
Compare
00e339b
to
65f7e46
Compare
65f7e46
to
5f2343d
Compare
5f2343d
to
0f8c01d
Compare
Why The frontend is now part of quickstart-vdk. On changes to the docker image, the helm chart needs to be redeployed. We need to make sure that the frontend is operational once the helm chart is deployed. What Trigger deployment of test control service on frontend changes merged into main Ping the frontend using heartbeat once control service is deployed Tag the frontend image as stable once heartbeat test passes How has this been tested CI What kind of change is this feature/non-breaking Signed-off-by: Dilyan Marinov <[email protected]>
13817d6
to
dacd5d8
Compare
duyguHsnHsn
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on top of #2138
Why
The frontend is now part of quickstart-vdk.
On changes to the docker image, the helm chart needs to be redeployed. We need to make sure that the frontend is operational once the helm chart is deployed.
What
Trigger deployment of test control service on frontend changes merged into main
Ping the frontend in the test environment using heartbeat once control service is deployed
Tag the frontend image as stable if the test is successful
How has this been tested
Test pipeline
What kind of change is this
feature, non-breaking