vdk-dag: DAGs propagate their execution type to their component jobs #2080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yoan Salambashev <[email protected]>
Signed-off-by: Yoan Salambashev <[email protected]>
Signed-off-by: Yoan Salambashev <[email protected]>
for more information, see https://pre-commit.ci
# Why We were using a version of the python client generator that had a few bugs in it. I opened tickets and they have fixed the bugs # What Upgrade the gradle plugin version and remove the hacks in the gradle codebase to workaround the existing issues. # How has this been tested I made a release of it locally and ran the vdk-control-cli tests using the newest python client library. Signed-off-by: murphp15 <[email protected]>
## Why? The explore page and widgets are not relevant to users outside of VMWare This also fixes the bug where the frontend does not load on running quickstart-vdk due to missing configuration ## What? Ignore the explore page and widgets in the control service helm chart ## How has this been tested? Configuration tested locally Helm chart tested in CI ## What type of change are you making? Bug fix (non-breaking change which fixes an issue) or a cosmetic change/minor improvement Signed-off-by: Dilyan Marinov <[email protected]>
# Why on the newest python api client we are getting failing test because we check more of the properties in the mock response. # What Return a dummy response. The dummy response which has the required properties. # How has this been tested ran tests locally --------- Signed-off-by: murphp15 <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
# Why We were using a version of the python client generator that had a few bugs in it. I opened tickets and they have fixed the bugs. in this PR #2076 I released the new version. # What Make a few small changes to make it compatible with the latest version # How has this been tested ran tests locally Signed-off-by: murphp15 <[email protected]>
…o 2.2.10 in /projects/control-service/projects/pipelines_control_service (#2066) Bumps io.swagger.core.v3:swagger-annotations from 2.2.9 to 2.2.10. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Yoan Salambashev <[email protected]>
for more information, see https://pre-commit.ci
gabrielgeorgiev1
approved these changes
May 18, 2023
projects/vdk-plugins/vdk-dag/src/vdk/plugin/dag/cached_data_job_executor.py
Show resolved
Hide resolved
antoniivanov
approved these changes
May 18, 2023
What: More informative and easy to understand Run message on notebook failure are introduced: On failure return more detailed error message (where the failure happened, what is the error) + a button which allows the user to navigate to the failing cell Here are some screenshots of the newly introduced cell marks: <img width="1229" alt="Screenshot 2023-05-11 at 16 17 36" src="https://github.com/vmware/versatile-data-kit/assets/87015481/9ad328a5-e833-4fd6-a6eb-bfd4f32166cd"> <img width="1229" alt="Screenshot 2023-05-11 at 16 17 51" src="https://github.com/vmware/versatile-data-kit/assets/87015481/aa1ac215-4e33-4569-92bb-641a1f95e654"> Here is a video how it works: https://github.com/vmware/versatile-data-kit/assets/87015481/5adbb894-b2c5-42b5-a448-6b747a66536e Why: This makes working with errors that are produced from notebook cells such more easier. Tests: jest tests Signed-off-by: Duygu Hasan [[email protected]](mailto:[email protected]) --------- Co-authored-by: github-actions <> Co-authored-by: murphp15 <[email protected]>
What: Pinned rendermime-interfaces to 3.6.3. Also removed "@cfaester/enzyme-adapter-react-18": "^0.6.0" which is not used and caused not frequent build errors. Why: Because jupyterlab 4 is released some days ago, and it bumps the latest version of rendermime-interface to 3.8.0, which is not compatible with lumino 1.x This caused Build issues:  Signed-off-by: Duygu Hasan [[email protected]](mailto:[email protected])
Signed-off-by: Yoan Salambashev <[email protected]>
Signed-off-by: murphp15 <[email protected]>
Signed-off-by: murphp15 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Currently, jobs ran by DAGs are labelled manual executions. This is due to the execution being triggered through the Execution API. Ideally, we would like that if a DAGs is a manual execution, then all component jobs are also manual execution, and likewise for scheduled runs. This change achieves this.
Why: To achieve consistency with the data jobs' execution type.
Testing Done: all tests are passing, introduced unit test
Signed-off-by: Yoan Salambashev [email protected]