control-service: fix oom tests #2028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: murphp15 <[email protected]>
murphp15
commented
May 9, 2023
...rvice/src/integration-test/java/com/vmware/taurus/datajobs/it/DataJobInitContainerOOMIT.java
Show resolved
Hide resolved
murphp15
commented
May 9, 2023
...rvice/src/integration-test/java/com/vmware/taurus/datajobs/it/DataJobInitContainerOOMIT.java
Show resolved
Hide resolved
murphp15
commented
May 9, 2023
...service/src/integration-test/java/com/vmware/taurus/datajobs/it/common/JobExecutionUtil.java
Show resolved
Hide resolved
murphp15
commented
May 9, 2023
...cts/pipelines_control_service/src/main/java/com/vmware/taurus/service/KubernetesService.java
Show resolved
Hide resolved
mivanov1988
approved these changes
May 9, 2023
|
Good job! |
ivakoleva
approved these changes
May 9, 2023
...cts/pipelines_control_service/src/main/java/com/vmware/taurus/service/KubernetesService.java
Show resolved
Hide resolved
Signed-off-by: murphp15 <[email protected]>
Signed-off-by: murphp15 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
In this PR I fix a very unstable oom test.
The test is very unstable for a number of reasons.
We can put the memory requirement any lower to ensure an error because 6mi is the lower limit supported by k8s.
What
I fix it by using a cronjob template which doesn't let the job restart. This means if it fails once it will report as failed.
How has this been tested?
integration tests.