Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdk-examples: Change Meta Jobs to DAGs in examples #2024

Merged
merged 4 commits into from
May 10, 2023

Conversation

gabrielgeorgiev1
Copy link
Contributor

This PR corrects two examples to bring them in line with the changed name of VDK DAGs. It also includes a note in the VEP to mention this change, however the VEP remains unchanged otherwise.

This PR corrects two examples to bring them in line with the changed
name of VDK DAGs. It also includes a note in the VEP to mention this
change, however the VEP remains unchanged otherwise.

Signed-off-by: Gabriel Georgiev <[email protected]>
Signed-off-by: Gabriel Georgiev <[email protected]>
…on/gageorgiev/correct-example-vep

Signed-off-by: Gabriel Georgiev <[email protected]>
Copy link
Contributor

@yonitoo yonitoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks very good, left a few comments.

Signed-off-by: Gabriel Georgiev <[email protected]>
Copy link
Contributor

@yonitoo yonitoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Ship it!

@gabrielgeorgiev1 gabrielgeorgiev1 enabled auto-merge (squash) May 10, 2023 07:20
@gabrielgeorgiev1 gabrielgeorgiev1 merged commit 7fb3a5d into main May 10, 2023
@gabrielgeorgiev1 gabrielgeorgiev1 deleted the person/gageorgiev/correct-example-vep branch May 10, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants