Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: Improve visibility of 'User error' messages #1960

Merged
merged 7 commits into from
Apr 27, 2023

Conversation

hzhristova
Copy link
Contributor

@hzhristova hzhristova commented Apr 25, 2023

Add new 'details' buttons to make error messages more visible. Note that these messages are not very frequent
Changes are needed in three pages:

  1. Manage Data Jobs grid
  2. Data Job Executions tab grid
  3. Details page - timeline (on both manage and explore sections)

In manage page grid and executions grid, 'details' buttons will appear when the execution status is 'User Error', 'Platform Error' or 'Skipped'.

When displaying in details page timeline, I show the entire error message without using signpost.

Testing done: verified locally

image
image
image

@antoniivanov
Copy link
Collaborator

Please post screenshots of the changes in the PR description perhaps.

Copy link
Collaborator

@antoniivanov antoniivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the screenshots . They are the primary thing I reviewed.

Looks good to me.

Note that these kind of messages would become more informative and detailed over time. Let's imagine it's 4 times as long as the current text. Would it still look OK?

@hzhristova
Copy link
Contributor Author

hzhristova commented Apr 26, 2023

Thanks for the notice, Antoni. If the message is longer, this wont be a problem for the signposts.
For the timelines, the first 50 words will be shown and if the message is longer, a 'Show more' button will appear and the user will be able to expand it all
image
image

@antoniivanov
Copy link
Collaborator

Thanks for the notice, Antoni. If the message is longer, this wont be a problem for the signposts. For the timelines, the first 50 words will be shown and if the message is longer, a 'Show more' button will appear and the user will be able to expand it

Thanks for checking. Looks good

@hzhristova hzhristova force-pushed the person/hzhristova/improve-errors-messages-visibility branch from 9927c11 to fe69387 Compare April 27, 2023 19:34
@hzhristova hzhristova merged commit 61fe07f into main Apr 27, 2023
@hzhristova hzhristova deleted the person/hzhristova/improve-errors-messages-visibility branch April 27, 2023 20:37
yonitoo pushed a commit that referenced this pull request May 3, 2023
Add new 'details' buttons to make error messages more visible. Note that
these messages are not very frequent
Changes are needed in three pages:
1. Manage Data Jobs grid
2. Data Job Executions tab grid
3. Details page - timeline (on both manage and explore sections)

In manage page grid and executions grid, 'details' buttons will appear
when the execution status is 'User Error', 'Platform Error' or
'Skipped'.

When displaying in details page timeline, I show the entire error
message without using signpost.

Testing done: verified locally


![image](https://user-images.githubusercontent.com/127503989/234296967-d776f764-3aa3-420d-9d66-6b9ee1ca6886.png)

![image](https://user-images.githubusercontent.com/127503989/234296997-033995e9-db01-4a8c-b100-b29e49ef46ba.png)

![image](https://user-images.githubusercontent.com/127503989/234297037-88b69bd6-ed7c-4df7-a303-e8fd2e2db3fb.png)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants