-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend: Improve visibility of 'User error' messages #1960
frontend: Improve visibility of 'User error' messages #1960
Conversation
Please post screenshots of the changes in the PR description perhaps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the screenshots . They are the primary thing I reviewed.
Looks good to me.
Note that these kind of messages would become more informative and detailed over time. Let's imagine it's 4 times as long as the current text. Would it still look OK?
Thanks for checking. Looks good |
9927c11
to
fe69387
Compare
Add new 'details' buttons to make error messages more visible. Note that these messages are not very frequent Changes are needed in three pages: 1. Manage Data Jobs grid 2. Data Job Executions tab grid 3. Details page - timeline (on both manage and explore sections) In manage page grid and executions grid, 'details' buttons will appear when the execution status is 'User Error', 'Platform Error' or 'Skipped'. When displaying in details page timeline, I show the entire error message without using signpost. Testing done: verified locally   
Add new 'details' buttons to make error messages more visible. Note that these messages are not very frequent
Changes are needed in three pages:
In manage page grid and executions grid, 'details' buttons will appear when the execution status is 'User Error', 'Platform Error' or 'Skipped'.
When displaying in details page timeline, I show the entire error message without using signpost.
Testing done: verified locally