Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

control-service: Expose supported python versions in helm #1935

Merged
merged 1 commit into from
Apr 25, 2023
Merged

control-service: Expose supported python versions in helm #1935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .../control-service/projects/helm_charts/pipelines-control-service/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,14 @@ spec:
value: "{{ .Values.dataJob.deployment.initContainer.resources.limits.memory }}"
- name: DATAJOBS_DEPLOYMENT_INITCONTAINER_RESOURCES_LIMITS_CPU
value: "{{ .Values.dataJob.deployment.initContainer.resources.limits.cpu }}"
{{- if .Values.deploymentDefaultPythonVersion }}
- name: DATAJOBS_DEPLOYMENT_DEFAULT_PYTHON_VERSION
value: "{{ .Values.deploymentDefaultPythonVersion }}"
{{- end }}
{{- if .Values.deploymentSupportedPythonVersions }}
- name: DATAJOBS_DEPLOYMENT_SUPPORTED_PYTHON_VERSIONS
value: {{ toJson .Values.deploymentSupportedPythonVersions }}
{{- end }}


{{- if .Values.extraVars }}
Expand Down
28 changes: 28 additions & 0 deletions projects/control-service/projects/helm_charts/pipelines-control-service/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,34 @@ deploymentDataJobBaseImage:
username:
password:


## The map of python versions for data job deployments supported by the Control Service.
## All values should be strings, and follow the format
## {"pythonVersion": {"baseImage": "<repository>:<tag>", "vdkImage": "<registry>/<repository>:<tag>"}}
##
## The value of baseImage will be used to create the image, where data job would be run.
## On top of it the job source and its dependencies are installed for each job.
## It can be customized further by installing other native dependencies necessary to run different kinds of libraries
##
## The value of vdkImage is the image name of VDK, which will be used to run the data jobs.
## It is recommended to use image with same tag (e.g., release or latest),
## as it will be pulled before any execution, thus making sure all jobs use the same and latest version of VDK.
## The image should contain installation of VDK (vdk), which will be used to run the data jobs (vdk run command)
## Only the installed python modules (vdk and its dependencies) will be used from the image.
## Everything else is effectively discarded since another image is used as base during execution.
##
## Example: {"3.9": {"baseImage": "python:3.9-latest", "vdkImage": "example-registry.com/some-user/vdk:3.9-release"}}
deploymentSupportedPythonVersions:
3.7:
baseImage: "registry.hub.docker.com/versatiledatakit/data-job-base-python-3.7:latest"
vdkImage: "registry.hub.docker.com/versatiledatakit/quickstart-vdk:release"


## Default python version to be used for data job deployments. The value should be a string and would be
## used when a user has not provided a specific python_version for their data job's deployment.
## Example: "3.9"
deploymentDefaultPythonVersion: "3.7"

## ini formatted options that provides default and per-job VDK options.
## Allows to provide VDK configuration via environment variables.
## They will be set as environment variables during execution of Data Job
Expand Down