-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
control-service: Expose supported python versions in helm #1935
Conversation
03f340a
to
7f7161b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, maybe tighten up the comments a bit since its a bit wall-of-text-y
When are you planning to deprecate the old properties? |
projects/control-service/projects/helm_charts/pipelines-control-service/values.yaml
Outdated
Show resolved
Hide resolved
7f7161b
to
d982bae
Compare
I was thinking of doing it in a separate PR, but I guess it wouldn't make much of a difference if it happens in this one. |
f560e22
to
230c12d
Compare
230c12d
to
2628ca2
Compare
As part of the initiative to support multiple python versions in data job deployments, new configurations were introduced in the form of `datajobs.deployment.supportedPythonVersions` and `datajobs.deployment.defaultPythonVersion` configuration properties. To facilitate proper production setup of the Control Service with the new functionality, the configuration needs to be exposed in the helm chart. This change updates the values.yaml and deployment.yaml files of the Control Service helm chart to expose the supportedPythonVersions and defaultPythonVersion configurations and set them as environment variables. Testing Done: CI/CD and local run of `helm lint` on the chart. Signed-off-by: Andon Andonov <[email protected]>
2628ca2
to
213f204
Compare
As part of the initiative to support multiple python versions for data job deployments, we introduced new configurations through the `datajobs.deployment.supportedPythonVersions` and `datajobs.deployment.defaultPythonVersion` properties. This new configuration renders the old configurations through `datajobs.vdk.image` and `datajobs.deployment.dataJobBaseImage` essentially useless, as these are no longer used. This change cleans up the old configurations and related code and tests, so that only the new configurations remain. A more descriptive list of the changes is as follows: * The `DOCKER_VDK_BASE_IMAGE` and `DATAJOBS_DEPLOYMENT_DATAJOBBASEIMAGE` environment variables are removed, as they are not needed anymore. * The templates associated with the above-mentioned env vars, projects/control-service/projects/helm_charts/pipelines-control-service/templates/_helpers.tpl, is also removed. * The JobImageDeployer, projects/control-service/projects/pipelines_control_service/src/main/java/com/vmware/taurus/service/deploy/JobImageDeployer.java, logic related to the stand-alone vdk image configuration is also cleaned up to use only the `supportedPythonVersions` functionality. Tests associated with the cleaned up logic are also removed. The new configurations were introduced in #2022 and #1935 Testing Done: CI/CD --------- Signed-off-by: Andon Andonov <[email protected]> Co-authored-by: github-actions <>
As part of the initiative to support multiple python versions in data job deployments, new configurations were introduced in the form of
datajobs.deployment.supportedPythonVersions
anddatajobs.deployment.defaultPythonVersion
configuration properties.To facilitate proper production setup of the Control Service with the new functionality, the configuration needs to be exposed in the helm chart.
This change updates the values.yaml and deployment.yaml files of the Control Service helm chart to expose the supportedPythonVersions and defaultPythonVersion configurations and set them as environment variables.
Testing Done: CI/CD and local run of
helm lint
on the chart.