Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: Align code formatting in frontend projects #1863

Merged
merged 2 commits into from
Apr 10, 2023
Merged

frontend: Align code formatting in frontend projects #1863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
348a8e5
frontend: Align code formatting in frontend projects
gorankokin Apr 7, 2023
e34fa21
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion projects/frontend/data-pipelines/gui/.editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ insert_final_newline = true
trim_trailing_whitespace = true

[*.{ts, html}]
max_line_length = 80
max_line_length = 140

[*.{ts, js}]
quote_type = single
Expand Down
11 changes: 10 additions & 1 deletion projects/frontend/data-pipelines/gui/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,16 @@
]
},
"import/resolver": {
"typescript": {}
"typescript": {
"project": [
"tsconfig.json"
]
},
"node": {
"project": [
"tsconfig.json"
]
}
}
},
"overrides": [
Expand Down
2 changes: 1 addition & 1 deletion projects/frontend/data-pipelines/gui/.prettierrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"semi": true,
"singleQuote": true,
"quoteProps": "as-needed",
"trailingComma": "all",
"trailingComma": "none",
"bracketSpacing": true,
"jsxBracketSameLine": true,
"arrowParens": "always",
Expand Down
8 changes: 4 additions & 4 deletions ...s/frontend/data-pipelines/gui/e2e/integration/app/getting-started/getting-started.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ describe('Getting Started Page', { tags: ['@dataPipelines'] }, () => {

return cy.wrap({
context: 'getting-started.spec::before()',
action: 'continue',
action: 'continue'
});
});
});
Expand All @@ -47,8 +47,8 @@ describe('Getting Started Page', { tags: ['@dataPipelines'] }, () => {
.getMainTitle()
.should(($el) =>
expect($el.text().trim()).to.equal(
'Get Started with Data Pipelines',
),
'Get Started with Data Pipelines'
)
);
});

Expand Down Expand Up @@ -113,7 +113,7 @@ describe('Getting Started Page', { tags: ['@dataPipelines'] }, () => {

// navigate to most recent failing job executions
dataJobsHealthPanel.navigateToMostRecentFailingJobExecutions(
testJob.job_name,
testJob.job_name
);

const dataJobManageExecutionsPage =
Expand Down
22 changes: 11 additions & 11 deletions projects/frontend/data-pipelines/gui/e2e/integration/lib/explore/data-job-details.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ describe(
before(() => {
return DataJobExploreDetailsPage.recordHarIfSupported()
.then(() =>
cy.clearLocalStorageSnapshot('data-job-explore-details'),
cy.clearLocalStorageSnapshot('data-job-explore-details')
)
.then(() => DataJobExploreDetailsPage.login())
.then(() => cy.saveLocalStorage('data-job-explore-details'))
Expand All @@ -30,7 +30,7 @@ describe(

return cy.wrap({
context: 'explore::data-job-details.spec::before()',
action: 'continue',
action: 'continue'
});
});
});
Expand All @@ -54,7 +54,7 @@ describe(

dataJobsExplorePage.openJobDetails(
testJobs[0].team,
testJobs[0].job_name,
testJobs[0].job_name
);

dataJobExploreDetailsPage = DataJobExploreDetailsPage.getPage();
Expand Down Expand Up @@ -86,7 +86,7 @@ describe(
.should('be.visible')
.should(
'contains.text',
'At 12:00 AM, on day 01 of the month, and on Friday',
'At 12:00 AM, on day 01 of the month, and on Friday'
);

// DISABLED Because there is no Source at the moment.
Expand All @@ -101,7 +101,7 @@ describe(
.should('be.visible')
.should(
'contains.text',
testJobs[0].config.contacts.notified_on_job_deploy,
testJobs[0].config.contacts.notified_on_job_deploy
);

dataJobExploreDetailsPage
Expand All @@ -110,7 +110,7 @@ describe(
.should(
'contains.text',
testJobs[0].config.contacts
.notified_on_job_failure_platform_error,
.notified_on_job_failure_platform_error
);

dataJobExploreDetailsPage
Expand All @@ -119,15 +119,15 @@ describe(
.should(
'contains.text',
testJobs[0].config.contacts
.notified_on_job_failure_user_error,
.notified_on_job_failure_user_error
);

dataJobExploreDetailsPage
.getOnSuccessField()
.should('be.visible')
.should(
'contains.text',
testJobs[0].config.contacts.notified_on_job_success,
testJobs[0].config.contacts.notified_on_job_success
);
});

Expand All @@ -138,7 +138,7 @@ describe(

dataJobsExplorePage.openJobDetails(
testJobs[0].team,
testJobs[0].job_name,
testJobs[0].job_name
);

const dataJobExploreDetailsPage =
Expand All @@ -162,7 +162,7 @@ describe(

dataJobsExplorePage.openJobDetails(
testJobs[0].team,
testJobs[0].job_name,
testJobs[0].job_name
);

const dataJobExploreDetailsPage =
Expand All @@ -179,5 +179,5 @@ describe(
.getActionDropdownBtn()
.should('not.exist');
});
},
}
);
14 changes: 7 additions & 7 deletions projects/frontend/data-pipelines/gui/e2e/integration/lib/explore/data-job-executions.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ describe(
before(() => {
return DataJobBasePO.recordHarIfSupported()
.then(() =>
cy.clearLocalStorageSnapshot('data-job-explore-executions'),
cy.clearLocalStorageSnapshot('data-job-explore-executions')
)
.then(() => DataJobBasePO.login())
.then(() => cy.saveLocalStorage('data-job-explore-executions'))
Expand All @@ -30,7 +30,7 @@ describe(

return cy.wrap({
context: 'explore::data-job-executions.spec::before()',
action: 'continue',
action: 'continue'
});
});
});
Expand All @@ -54,7 +54,7 @@ describe(

dataJobsExplorePage.openJobDetails(
testJobs[0].team,
testJobs[0].job_name,
testJobs[0].job_name
);

const dataJobBasePage = DataJobBasePO.getPage();
Expand All @@ -71,7 +71,7 @@ describe(

it('Data Job Explore Executions Page - should verify on URL navigate to Executions will redirect to Details', () => {
const dataJobBasePage = DataJobBasePO.navigateToUrl(
`/explore/data-jobs/${testJobs[0].team}/${testJobs[0].job_name}/executions`,
`/explore/data-jobs/${testJobs[0].team}/${testJobs[0].job_name}/executions`
);

dataJobBasePage
Expand All @@ -84,11 +84,11 @@ describe(
.should(
'match',
new RegExp(
`\\/explore\\/data-jobs\\/${testJobs[0].team}\\/${testJobs[0].job_name}\\/details$`,
),
`\\/explore\\/data-jobs\\/${testJobs[0].team}\\/${testJobs[0].job_name}\\/details$`
)
);

dataJobBasePage.getDetailsTab().should('have.class', 'active');
});
},
}
);
18 changes: 9 additions & 9 deletions projects/frontend/data-pipelines/gui/e2e/integration/lib/explore/data-jobs.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ describe(

return cy.wrap({
context: 'explore::data-jobs.spec::before()',
action: 'continue',
action: 'continue'
});
});
});
Expand All @@ -52,7 +52,7 @@ describe(
.getMainTitle()
.should('be.visible')
.should(($el) =>
expect($el.text().trim()).to.equal('Explore Data Jobs'),
expect($el.text().trim()).to.equal('Explore Data Jobs')
);
});

Expand Down Expand Up @@ -114,13 +114,13 @@ describe(
dataJobsExplorePage.refreshDataGrid();

dataJobsExplorePage.filterByJobName(
normalizedTestJob.job_name,
normalizedTestJob.job_name
);

dataJobsExplorePage
.getDataGridCell(normalizedTestJob.job_name)
.should('have.text', normalizedTestJob.job_name);
},
}
);
});

Expand Down Expand Up @@ -251,7 +251,7 @@ describe(
.invoke('join', ',')
.should(
'eq',
'Description,Deployment Status,Last Execution Duration,Success rate,Next run (UTC),Last Deployed (UTC),Last Deployed By,Source,Logs',
'Description,Deployment Status,Last Execution Duration,Success rate,Next run (UTC),Last Deployed (UTC),Last Deployed By,Source,Logs'
);

// verify column is not checked in toggling menu
Expand All @@ -267,7 +267,7 @@ describe(

// toggle column to render
dataJobsExplorePage.checkColumnShowHideOption(
'Last Execution Duration',
'Last Execution Duration'
);

// verify column is checked in toggling menu
Expand All @@ -283,7 +283,7 @@ describe(

// toggle column to hide
dataJobsExplorePage.uncheckColumnShowHideOption(
'Last Execution Duration',
'Last Execution Duration'
);

// verify column is not checked in toggling menu
Expand All @@ -308,7 +308,7 @@ describe(

dataJobsExplorePage.openJobDetails(
testJobs[0].team,
testJobs[0].job_name,
testJobs[0].job_name
);

const dataJobExploreDetailsPage =
Expand All @@ -324,5 +324,5 @@ describe(
.should('be.visible')
.should('contain.text', testJobs[0].description);
});
},
}
);
Loading