vdk-control-cli: vdk list -mmm to return executions #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assert_click_status is both shorter and provides more details in case of failures . Hence using it to check status is better Testing Done: CI Signed-off-by: Antoni Ivanov <[email protected]>
Added one more "m" in `vdk list -mmmm` to show execution details It is aligned somewhat how the UI looks. Generally this is useful and quick solution if UI is not available. Testing Done: unit tests Signed-off-by: Antoni Ivanov <[email protected]>
|
Seems like a nice addition from a usability perspective. |
dvalkova
approved these changes
Apr 3, 2023
dakodakov
approved these changes
Apr 4, 2023
yonitoo
pushed a commit
that referenced
this pull request
Apr 4, 2023
Added one more "m" in `vdk list -mmmm` to show execution details It is aligned somewhat how the UI looks. Generally this is useful and quick solution if UI is not available. Testing Done: unit tests --------- Signed-off-by: Antoni Ivanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added one more "m" in
vdk list -mmmmto show execution details It is aligned somewhat how the UI looks.Generally this is useful and quick solution if UI is not available.
Testing Done: unit tests