Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdk-jupyter: add py-to-ts-interfaces to build #1765

Merged
merged 4 commits into from
Mar 22, 2023

Conversation

duyguHsnHsn
Copy link
Collaborator

What:
Added py-to-ts-interfaces to build.

What the changes do:

  • Instruct npm to download the py-to-ts-interfaces package from the main branch of the repository located at https://github.com/Syndallic/py-to-ts-interfaces
  • build script by updating the "build:interfaces" script in the package.json (the npx command is used to run the installed py-to-ts-interfaces package)

Why: linked to the issue #1690

Tests: tested manually the build by adding new options to VdkOptions in the python project

Signed-off-by: Duygu Hasan [email protected]

Copy link
Contributor

@DeltaMichael DeltaMichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ok for a first iteration. Maybe you can create a shell script that checks if the package is installed, checks the version, and then tries to run it. You can scope this as additional effort.

@duyguHsnHsn
Copy link
Collaborator Author

This is ok for a first iteration. Maybe you can create a shell script that checks if the package is installed, checks the version, and then tries to run it. You can scope this as additional effort.

Issue created:
#1770

@duyguHsnHsn duyguHsnHsn merged commit 9b1d8b8 into main Mar 22, 2023
@duyguHsnHsn duyguHsnHsn deleted the person/hduygu/vdk-jupyter-py-to-ts-interfaces branch March 22, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants