Control Service: Add supported python version configuration #1761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doks5
requested review from
antoniivanov,
mivanov1988 and
murphp15
and removed request for
antoniivanov
ivakoleva
reviewed
Mar 21, 2023
..._control_service/src/main/java/com/vmware/taurus/service/deploy/SupportedPythonVersions.java
Outdated
Show resolved
Hide resolved
doks5
force-pushed
the
person/andonova/impl-pyver-spec
branch
from
89cfb9c to
cdc3d20
Compare
..._control_service/src/main/java/com/vmware/taurus/service/deploy/SupportedPythonVersions.java
Outdated
Show resolved
Hide resolved
...pelines_control_service/src/main/java/com/vmware/taurus/service/deploy/JobImageDeployer.java
Outdated
Show resolved
Hide resolved
...cts/control-service/projects/helm_charts/pipelines-control-service/templates/deployment.yaml
Outdated
Show resolved
Hide resolved
..._control_service/src/main/java/com/vmware/taurus/service/deploy/SupportedPythonVersions.java
Outdated
Show resolved
Hide resolved
..._control_service/src/main/java/com/vmware/taurus/service/deploy/SupportedPythonVersions.java
Outdated
Show resolved
Hide resolved
mivanov1988
reviewed
Mar 22, 2023
..._control_service/src/main/java/com/vmware/taurus/service/deploy/SupportedPythonVersions.java
Outdated
Show resolved
Hide resolved
mivanov1988
reviewed
Mar 22, 2023
..._control_service/src/main/java/com/vmware/taurus/service/deploy/SupportedPythonVersions.java
Outdated
Show resolved
Hide resolved
mivanov1988
reviewed
Mar 22, 2023
..._control_service/src/main/java/com/vmware/taurus/service/deploy/SupportedPythonVersions.java
Outdated
Show resolved
Hide resolved
mivanov1988
reviewed
Mar 22, 2023
..._control_service/src/main/java/com/vmware/taurus/service/deploy/SupportedPythonVersions.java
Outdated
Show resolved
Hide resolved
mivanov1988
reviewed
Mar 22, 2023
...ol-service/projects/pipelines_control_service/src/main/resources/application-prod.properties
Outdated
Show resolved
Hide resolved
doks5
force-pushed
the
person/andonova/impl-pyver-spec
branch
from
7d115a7 to
efbd4a0
Compare
doks5
force-pushed
the
person/andonova/impl-pyver-spec
branch
2 times, most recently
from
74607e0 to
219407b
Compare
mivanov1988
reviewed
Mar 24, 2023
...control-service/projects/pipelines_control_service/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
mivanov1988
reviewed
Mar 24, 2023
..._control_service/src/main/java/com/vmware/taurus/service/deploy/SupportedPythonVersions.java
Outdated
Show resolved
Hide resolved
mivanov1988
reviewed
Mar 24, 2023
..._control_service/src/main/java/com/vmware/taurus/service/deploy/SupportedPythonVersions.java
Outdated
Show resolved
Hide resolved
mivanov1988
reviewed
Mar 24, 2023
..._control_service/src/main/java/com/vmware/taurus/service/deploy/SupportedPythonVersions.java
Outdated
Show resolved
Hide resolved
mivanov1988
reviewed
Mar 24, 2023
..._control_service/src/main/java/com/vmware/taurus/service/deploy/SupportedPythonVersions.java
Show resolved
Hide resolved
mivanov1988
reviewed
Mar 24, 2023
..._control_service/src/main/java/com/vmware/taurus/service/deploy/SupportedPythonVersions.java
Outdated
Show resolved
Hide resolved
mivanov1988
reviewed
Mar 24, 2023
..._control_service/src/main/java/com/vmware/taurus/service/deploy/SupportedPythonVersions.java
Show resolved
Hide resolved
mivanov1988
reviewed
Mar 24, 2023
..._control_service/src/main/java/com/vmware/taurus/service/deploy/SupportedPythonVersions.java
Outdated
Show resolved
Hide resolved
mivanov1988
reviewed
Mar 24, 2023
...trol_service/src/test/java/com/vmware/taurus/service/deploy/SupportedPythonVersionsTest.java
Outdated
Show resolved
Hide resolved
antoniivanov
approved these changes
Mar 27, 2023
doks5
force-pushed
the
person/andonova/impl-pyver-spec
branch
from
0036586 to
987317c
Compare
murphp15
approved these changes
Mar 27, 2023
As part of the effort to support different python versions for data job deployments in Versatile Data Kit, we need to be able to configure what python versions are supported by the Control Service. This change adds new configuration to the Control Service's helm chart, which allows administrators of the service to specify what python versions are allowed for deployments and what vdk and job base images are to be used for the corresponding python versions. The configuration is in the form of a map as described in VEP-1739 and is injected in the Control Service deployment as a `DATAJOBS_DEPLOYMENT_SUPPORTED_PYTHON_VERSIONS` environment variable. The configuration is also added to the service's application properties files. Additionally, a set of methods is implemented to support a variety of use cases related to accecssing and managing the supported python versions configuration. Testing Done: Unit tests added. Signed-off-by: Andon Andonov <[email protected]>
Signed-off-by: Andon Andonov <[email protected]>
Signed-off-by: Andon Andonov <[email protected]>
Signed-off-by: Andon Andonov <[email protected]>
Signed-off-by: Andon Andonov <[email protected]>
Signed-off-by: Andon Andonov <[email protected]>
Signed-off-by: Andon Andonov <[email protected]>
Signed-off-by: Andon Andonov <[email protected]>
Signed-off-by: Andon Andonov <[email protected]>
doks5
force-pushed
the
person/andonova/impl-pyver-spec
branch
from
62c848a to
17a099c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the effort to support different python versions for data job deployments in Versatile Data Kit, we need to be able to configure what python versions are supported by the Control Service.
This change adds new configuration to the Control Service's helm chart, which allows administrators of the service to specify what python versions are allowed for deployments and what vdk and job base images are to be used for the corresponding python versions. The configuration is in the form of a map as described in VEP-1739 and is injected in the Control Service deployment as a
DATAJOBS_DEPLOYMENT_SUPPORTED_PYTHON_VERSIONSenvironment variable.The configuration is also added to the service's application properties files.
Additionally, a set of methods is implemented to support a variety of use cases related to accecssing and managing the supported python versions configuration.
Testing Done: Unit tests added.