-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend: e2e tests wiring and clientid #1754
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An OAuth application had to be provisioned with CSP STG. Provisioned the OAuth application, and configured the client ID. Testing done: authenticated successfully with starting the application locally, backed by our CI/CD control-service instance. Signed-off-by: ivakoleva <[email protected]>
An OAuth application had to be provisioned with CSP STG. Provisioned the OAuth application, and configured the client ID. Testing done: authenticated successfully with starting the application locally, backed by our CI/CD control-service instance. Signed-off-by: ivakoleva <[email protected]>
An OAuth application had to be provisioned with CSP STG. Needed to wire the e2e tests execution to verify code changes. Provisioned the OAuth application, and configured the client ID. Added a script to run the e2e tests, and a gitlab ci task to run it. Testing done: authenticated successfully with starting the application locally, backed by our CI/CD control-service instance. Signed-off-by: ivakoleva <[email protected]>
An OAuth application had to be provisioned with CSP STG. Needed to wire the e2e tests execution to verify code changes. Provisioned the OAuth application, and configured the client ID. Added a script to run the e2e tests, and a gitlab ci task to run it. Testing done: authenticated successfully with starting the application locally, backed by our CI/CD control-service instance. Signed-off-by: ivakoleva <[email protected]>
An OAuth application had to be provisioned with CSP STG. Needed to wire the e2e tests execution to verify code changes. Provisioned the OAuth application, and configured the client ID. Added a script to run the e2e tests, and a gitlab ci task to run it. Testing done: authenticated successfully with starting the application locally, backed by our CI/CD control-service instance. Signed-off-by: ivakoleva <[email protected]>
An OAuth application had to be provisioned with CSP STG. Needed to wire the e2e tests execution to verify code changes. Provisioned the OAuth application, and configured the client ID. Added a script to run the e2e tests, and a gitlab ci task to run it. Testing done: authenticated successfully with starting the application locally, backed by our CI/CD control-service instance. Signed-off-by: ivakoleva <[email protected]>
A prerequisite is a control-service instance running. Auth configured with CSP STG provisioned OAuth app, redirect URLs and TTL set common to the prior app configs. e2e tests sync to freezepoint - Had to fetch the latest changes from the internal repo contributed, to unify the diverged with the public repo. Added test_e2e_data_pipelines.sh script for cicd/local dev purposes. Added Gitlab job to run. Provisioned the clientId with CSP STG. Synced the `frontend/data-pipelines/gui/e2e/*` This PR is dependent on syncing the functional changes in the scope of: #1746 Testing done: ci/cd; run locally `npm start` and `node --max_old_space_size=4096 ./node_modules/cypress/bin/cypress open --env OAUTH2_API_TOKEN=$VDK_API_TOKEN,CYPRESS_TERMINAL_LOGS='./e2e/logs'` where auth is successful Testing the e2e tests functional changes will be additionally done. Signed-off-by: ivakoleva <[email protected]>
A prerequisite is a control-service instance running. Auth configured with CSP STG provisioned OAuth app, redirect URLs and TTL set common to the prior app configs. e2e tests sync to freezepoint - Had to fetch the latest changes from the internal repo contributed, to unify the diverged with the public repo. Added test_e2e_data_pipelines.sh script for cicd/local dev purposes. Added Gitlab job to run. Provisioned the clientId with CSP STG. Synced the `frontend/data-pipelines/gui/e2e/*` This PR is dependent on syncing the functional changes in the scope of: #1746 Testing done: ci/cd; run locally `npm start` and `node --max_old_space_size=4096 ./node_modules/cypress/bin/cypress open --env OAUTH2_API_TOKEN=$VDK_API_TOKEN,CYPRESS_TERMINAL_LOGS='./e2e/logs'` where auth is successful Testing the e2e tests functional changes will be additionally done. Signed-off-by: ivakoleva <[email protected]>
A prerequisite is a control-service instance running. Auth configured with CSP STG provisioned OAuth app, redirect URLs and TTL set common to the prior app configs. e2e tests sync to freezepoint - Had to fetch the latest changes from the internal repo contributed, to unify the diverged with the public repo. Added test_e2e_data_pipelines.sh script for cicd/local dev purposes. Added Gitlab job to run. Provisioned the clientId with CSP STG. Synced the `frontend/data-pipelines/gui/e2e/*` This PR is dependent on syncing the functional changes in the scope of: #1746 Testing done: ci/cd; run locally `npm start` and `node --max_old_space_size=4096 ./node_modules/cypress/bin/cypress open --env OAUTH2_API_TOKEN=$VDK_API_TOKEN,CYPRESS_TERMINAL_LOGS='./e2e/logs'` where auth is successful Testing the e2e tests functional changes will be additionally done. Signed-off-by: ivakoleva <[email protected]>
A prerequisite is a control-service instance running. Auth configured with CSP STG provisioned OAuth app, redirect URLs and TTL set common to the prior app configs. e2e tests sync to freezepoint - Had to fetch the latest changes from the internal repo contributed, to unify the diverged with the public repo. Added test_e2e_data_pipelines.sh script for cicd/local dev purposes. Added Gitlab job to run. Provisioned the clientId with CSP STG. Synced the `frontend/data-pipelines/gui/e2e/*` This PR is dependent on syncing the functional changes in the scope of: #1746 Testing done: ci/cd; run locally `npm start` and `node --max_old_space_size=4096 ./node_modules/cypress/bin/cypress open --env OAUTH2_API_TOKEN=$VDK_API_TOKEN,CYPRESS_TERMINAL_LOGS='./e2e/logs'` where auth is successful Testing the e2e tests functional changes will be additionally done. Signed-off-by: ivakoleva <[email protected]>
A prerequisite is a control-service instance running. Auth configured with CSP STG provisioned OAuth app, redirect URLs and TTL set common to the prior app configs. e2e tests sync to freezepoint - Had to fetch the latest changes from the internal repo contributed, to unify the diverged with the public repo. Added test_e2e_data_pipelines.sh script for cicd/local dev purposes. Added Gitlab job to run. Provisioned the clientId with CSP STG. Synced the `frontend/data-pipelines/gui/e2e/*` This PR is dependent on syncing the functional changes in the scope of: #1746 Testing done: ci/cd; run locally `npm start` and `node --max_old_space_size=4096 ./node_modules/cypress/bin/cypress open --env OAUTH2_API_TOKEN=$VDK_API_TOKEN,CYPRESS_TERMINAL_LOGS='./e2e/logs'` where auth is successful Testing the e2e tests functional changes will be additionally done. Signed-off-by: ivakoleva <[email protected]>
A prerequisite is a control-service instance running. Auth configured with CSP STG provisioned OAuth app, redirect URLs and TTL set common to the prior app configs. e2e tests sync to freezepoint - Had to fetch the latest changes from the internal repo contributed, to unify the diverged with the public repo. Added test_e2e_data_pipelines.sh script for cicd/local dev purposes. Added Gitlab job to run. Provisioned the clientId with CSP STG. Synced the `frontend/data-pipelines/gui/e2e/*` This PR is dependent on syncing the functional changes in the scope of: #1746 Testing done: ci/cd; run locally `npm start` and `node --max_old_space_size=4096 ./node_modules/cypress/bin/cypress open --env OAUTH2_API_TOKEN=$VDK_API_TOKEN,CYPRESS_TERMINAL_LOGS='./e2e/logs'` where auth is successful Testing the e2e tests functional changes will be additionally done. Signed-off-by: ivakoleva <[email protected]>
A prerequisite is a control-service instance running. Auth configured with CSP STG provisioned OAuth app, redirect URLs and TTL set common to the prior app configs. e2e tests sync to freezepoint - Had to fetch the latest changes from the internal repo contributed, to unify the diverged with the public repo. Added test_e2e_data_pipelines.sh script for cicd/local dev purposes. Added Gitlab job to run. Provisioned the clientId with CSP STG. Synced the `frontend/data-pipelines/gui/e2e/*` This PR is dependent on syncing the functional changes in the scope of: #1746 Testing done: ci/cd; run locally `npm start` and `node --max_old_space_size=4096 ./node_modules/cypress/bin/cypress open --env OAUTH2_API_TOKEN=$VDK_API_TOKEN,CYPRESS_TERMINAL_LOGS='./e2e/logs'` where auth is successful Testing the e2e tests functional changes will be additionally done. Signed-off-by: ivakoleva <[email protected]>
This reverts commit 40236a7.
A prerequisite is a control-service instance running. Auth configured with CSP STG provisioned OAuth app, redirect URLs and TTL set common to the prior app configs. e2e tests sync to freezepoint - Had to fetch the latest changes from the internal repo contributed, to unify the diverged with the public repo. Added test_e2e_data_pipelines.sh script for cicd/local dev purposes. Added Gitlab job to run. Provisioned the clientId with CSP STG. Synced the `frontend/data-pipelines/gui/e2e/*` This PR is dependent on syncing the functional changes in the scope of: #1746 Testing done: ci/cd; run locally `npm start` and `node --max_old_space_size=4096 ./node_modules/cypress/bin/cypress open --env OAUTH2_API_TOKEN=$VDK_API_TOKEN,CYPRESS_TERMINAL_LOGS='./e2e/logs'` where auth is successful Testing the e2e tests functional changes will be additionally done. Signed-off-by: ivakoleva <[email protected]>
projects/frontend/data-pipelines/gui/e2e/integration/lib/explore/data-jobs.spec.js
Show resolved
Hide resolved
An OAuth application had to be provisioned with CSP STG. Needed to wire the e2e tests execution to verify code changes. Provisioned the OAuth application, and configured the client ID. Added a script to run the e2e tests, and a gitlab ci task to run it. Added also unit test coverage to gitlab artifacts per frontend component. Added to artifacts also data-pipelines e2e reports. Added issue on continuously failing explore page search tests fix: #1764 Added issue on headless mode fix: #1766 Updated the VEP-1507 on e2e testing during CI. Testing done: authenticated successfully with starting the application locally, backed by our CI/CD control-service instance. Signed-off-by: ivakoleva <[email protected]>
An OAuth application had to be provisioned with CSP STG. Needed to wire the e2e tests execution to verify code changes. Provisioned the OAuth application, and configured the client ID. Added a script to run the e2e tests, and a gitlab ci task to run it. Added also unit test coverage to gitlab artifacts per frontend component. Added to artifacts also data-pipelines e2e reports. Added issue on continuously failing explore page search tests fix: #1764 Added issue on headless mode fix: #1766 Updated the VEP-1507 on e2e testing during CI. Testing done: authenticated successfully with starting the application locally, backed by our CI/CD control-service instance. Signed-off-by: ivakoleva <[email protected]>
All tests passed: |
antoniivanov
approved these changes
Mar 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I left a comment that might be me not understanding things also.
DeltaMichael
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An OAuth application had to be provisioned with CSP STG. Needed to wire
the e2e tests execution to verify code changes.
Provisioned the OAuth application, and configured the client ID.
Added a script to run the e2e tests, and a gitlab ci task to run it.
Added also unit test coverage to gitlab artifacts per frontend component.
Added to artifacts also data-pipelines e2e reports.
Added issue on continuously failing explore page search tests fix:
#1764
Added issue on headless mode fix:
#1766
Updated the VEP-1507 on e2e testing during CI.
Testing done: authenticated successfully with starting the application
locally, backed by our CI/CD control-service instance.