-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
specs: VEP-1739 Support for Multiple Python Versions #1748
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for suggesting and driving this change. The proposal is generally well-structured and addresses the problem at hand effectively.
I have made some suggestions to further improve the proposal.
specs/vep-1739-multiple-python-versions/diagrams/high_level_design_plantUML_source.txt
Outdated
Show resolved
Hide resolved
specs/vep-1739-multiple-python-versions/diagrams/high_level_sequence_plantUML_source.txt
Outdated
Show resolved
Hide resolved
specs/vep-1739-multiple-python-versions/diagrams/high_level_sequence_plantUML_source.txt
Outdated
Show resolved
Hide resolved
3bb4163
to
f37f23d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for driving this effort for improving usability in terms of granular data job runtime environment configurations.
f37f23d
to
da75797
Compare
specs/vep-1739-multiple-python-versions/diagrams/high_level_sequence_plantUML_source.txt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I made suggestion to improve sequence diagram only.
da75797
to
3e6bf0f
Compare
I approved it because I think the Motivation, Requirements and High level design sections are good to be merged. For the detailed design I think we should cover
It's fine if some details are not yet clear and can be filled in the middle of the implementation when they become clearer |
3e6bf0f
to
e69a6a7
Compare
Hi, @tozka Indeed, more details will be added with subsequent PR. For this one, I've updated the diagrams and added the initial parts of the detailed design and the public API changes. |
Few comments regarding the sequence diagram:
|
This change introduces VDP-1739, which aims at proposing an improvement to Versatile Data Kit by adding support for using different python versions for data job deployments. Testing Done: N/A Signed-off-by: Andon Andonov <[email protected]>
e69a6a7
to
3e5a10a
Compare
Hi, @mivanov1988 Just updated the diagram to make the actual flow clearer. |
This change introduces VDP-1739, which aims at proposing an improvement to Versatile Data Kit by adding support for using different python versions for data job deployments.
Testing Done: N/A