Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update VEP-1507 with CI/CD description #1707

Merged
merged 3 commits into from
Mar 14, 2023
Merged

docs: Update VEP-1507 with CI/CD description #1707

merged 3 commits into from
Mar 14, 2023

Conversation

DeltaMichael
Copy link
Contributor

No description provided.

ivakoleva
ivakoleva approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@ivakoleva ivakoleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LVGTM, lean and well made explanations. Looks great.
You can also try getting early feedback from frontend adopters.

@DeltaMichael DeltaMichael force-pushed the person/mdilyan/cicd-vep branch from 31dd5fd to 0a81d35 Compare March 8, 2023 15:31
antoniivanov
antoniivanov reviewed Mar 9, 2023
View reviewed changes
Copy link
Collaborator

@antoniivanov antoniivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall design for CI/CD for frontend components looks solid. Below I have made suggestions that could enhance and make the design more clear.

@DeltaMichael DeltaMichael force-pushed the person/mdilyan/cicd-vep branch from 0a81d35 to 1272df5 Compare March 9, 2023 09:59
@DeltaMichael DeltaMichael force-pushed the person/mdilyan/cicd-vep branch 3 times, most recently from f7f3da2 to 76518c6 Compare March 14, 2023 08:45
@DeltaMichael DeltaMichael force-pushed the person/mdilyan/cicd-vep branch from 76518c6 to 139a7f3 Compare March 14, 2023 08:48
@ivakoleva ivakoleva requested a review from gorankokin March 14, 2023 09:01
@DeltaMichael DeltaMichael enabled auto-merge (squash) March 14, 2023 09:32
@DeltaMichael DeltaMichael merged commit 39f6c7b into main Mar 14, 2023
@DeltaMichael DeltaMichael deleted the person/mdilyan/cicd-vep branch March 14, 2023 09:52
ivakoleva pushed a commit that referenced this pull request Mar 16, 2023
@DeltaMichael @ivakoleva
docs: Update VEP-1507 with CI/CD description (#1707)
af485c0 
Signed-off-by: Dilyan Marinov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivakoleva ivakoleva ivakoleva approved these changes

@antoniivanov antoniivanov antoniivanov approved these changes

@gorankokin gorankokin Awaiting requested review from gorankokin gorankokin is a code owner

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DeltaMichael @antoniivanov @ivakoleva @vmwclabot