control-service: Update helm template license headers #1670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniivanov
requested changes
Feb 23, 2023
DeltaMichael
force-pushed
the
person/mdilyan/helm-template-license
branch
from
0a4044d to
89ec5cd
Compare
What Update helm template license headers to use template-style comments Ignore helm templates in pre-commit yaml license hook Create new pre-commit license hook to add template-style comments to helm templates Why Regular yaml comments at the top of files break parsing for helm charts This breaks control-service deployments How was this tested Tested installing the charts on a local k8s cluster using helm Signed-off-by: Dilyan Marinov <[email protected]>
DeltaMichael
force-pushed
the
person/mdilyan/helm-template-license
branch
from
89ec5cd to
dbf5629
Compare
It is good idea when doing any manual testing to include the actual commands being executed in the 'manual' test and some relevant for verification output of the command. That makes it clearer what exactly was tested and easier to review if something could be tested better. |
antoniivanov
approved these changes
Feb 23, 2023
ivakoleva
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update helm template license headers to use template-style comments Ignore helm templates in pre-commit yaml license hook Create new pre-commit license hook to add template-style comments to helm templates
Why
Regular yaml comments at the top of files break parsing for helm charts This breaks control-service deployments
How was this tested
Tested installing the charts on a local k8s cluster using helm
Ran
helm upgrade --install --debug --wait --timeout 10m0s cicd-control-service .on the chart, which gave me the same output as the failing pipeline. Edited the comments until the apiVersion error disappeared.https://gitlab.com/vmware-analytics/versatile-data-kit/-/jobs/3813924321