-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base-job-image: automatic image cleanup #1636
Conversation
Is the gradle jar necessary? |
No, it is not. Thanks! |
If I understand correctly (IIUC) , this tests the creation of the image. WIth a lot of job-builder images (2 or 3) we need some way to deploy them and run them. Have you thought about that ? |
It does not test the image, it produces a cleaner one. The testing strategy remains the same through the |
In pre_release_test we test against deployed version of the control service and that version uses data-job-base-python-3.7 base image and not this one. Which means this image is not tested. I think we need a strategy for testing it. Until then we should consider the image in development only really (dev version - 0.y.z). |
I think we are ready to switch to the secure one. |
# Why Currently, the base job image contains a lot of binaries/executables (including the package manager) which increases the attack surface of the data job. # What Integrated [docker-slim](https://github.com/slimtoolkit/slim) in order to reduce the number of binaries/executables. Docker-slim analyzes the image and produces a much cleaner one based on the application usage. # Testing done Local execution of docker-slim and CI/CD - https://gitlab.com/vmware-analytics/versatile-data-kit/-/jobs/3768967625. Signed-off-by: Miroslav Ivanov [email protected]
Why
Currently, the base job image contains a lot of binaries/executables (including the package manager) which increases the attack surface of the data job.
What
Integrated docker-slim in order to reduce the number of binaries/executables. Docker-slim analyzes the image and produces a much cleaner one based on the application usage.
Testing done
Local execution of docker-slim and CI/CD - https://gitlab.com/vmware-analytics/versatile-data-kit/-/jobs/3768967625.
Signed-off-by: Miroslav Ivanov [email protected]