Control-service: Remove dependency on old docker image which is not needed #1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: murphp15 <[email protected]>
Signed-off-by: murphp15 <[email protected]>
Signed-off-by: murphp15 <[email protected]>
murphp15
changed the title
Signed-off-by: murphp15 <[email protected]>
Signed-off-by: murphp15 <[email protected]>
Signed-off-by: murphp15 <[email protected]>
Signed-off-by: murphp15 <[email protected]>
Signed-off-by: murphp15 <[email protected]>
Signed-off-by: murphp15 <[email protected]>
Signed-off-by: murphp15 <[email protected]>
Signed-off-by: murphp15 <[email protected]>
Signed-off-by: murphp15 <[email protected]>
murphp15
changed the title
Signed-off-by: murphp15 <[email protected]>
mivanov1988
approved these changes
Jan 24, 2023
|
LGTM! |
antoniivanov
approved these changes
Jan 25, 2023
There was a problem hiding this comment.
Yes, The authenticator is no longer needed:
https://docs.aws.amazon.com/eks/latest/userguide/install-aws-iam-authenticator.html
If you're running the AWS CLI version 1.16.156 or later, then you don't need to install the authenticator. Instead, you can use the aws eks get-token command. For more information, see Create kubeconfig file manually.
antoniivanov
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The old docker image with the aws-iam-authenticator is giving us a lot of trouble. we don't need it.
Removing it, everything works well.
What
Change the image we are using
How has this been tested?
At the commit c483219 I pushed extra changes to run the actual deployment to make sure it worked. Then reverted them when everything looked good.