vdk-jupyter: modify the way we read notebooks in notebook plugin #1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivakoleva
approved these changes
Jan 19, 2023
projects/vdk-plugins/vdk-notebook/src/vdk/plugin/notebook/notebook_based_step.py
Show resolved
Hide resolved
projects/vdk-plugins/vdk-notebook/src/vdk/plugin/notebook/notebook.py
Outdated
Show resolved
Hide resolved
duyguHsnHsn
force-pushed
the
person/hduygu/vdk-notebook-read
branch
from
b46b12a to
bc10620
Compare
for more information, see https://pre-commit.ci
antoniivanov
approved these changes
Jan 19, 2023
murphp15
reviewed
Jan 19, 2023
projects/vdk-plugins/vdk-notebook/src/vdk/plugin/notebook/notebook.py
Outdated
Show resolved
Hide resolved
murphp15
reviewed
Jan 19, 2023
|
I love the diagrams |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Changes on the way we read the JSON schema of a notebook.
Why:
Since we introduced job_input as Jupyter variable with an iPython extension see #1483 , our users now have direct access to the job_input variable and no longer need to use def run function to access it.
Testing: Unit tests
Signed-off-by: Duygu Hasan [email protected]