control-service: builder images load secrets from k8s #1358
Conversation
Why What How was this tested tested extensivly locally and it works very well and leads to faster dev iteration cycles. Signed-off-by: murphp15 <[email protected]>
Why What How was this tested tested extensivly locally and it works very well and leads to faster dev iteration cycles. Signed-off-by: murphp15 <[email protected]>
Why What How was this tested tested extensivly locally and it works very well and leads to faster dev iteration cycles. Signed-off-by: murphp15 <[email protected]>
murphp15
requested review from
ivakoleva,
gabrielgeorgiev1 and
mivanov1988
and removed request for
ivakoleva and
gabrielgeorgiev1
...elines_control_service/src/integration-test/resources/application-private-builder.properties
Show resolved
Hide resolved
|
Currently our main user facing documentation of the Control Service configuration is primary though helm chart values.yaml so this would need to be documented there as well. but we do need more user-friendly one and examples /tutorials - so the ticket that you opened can be about that. |
I am not going to do this now, but in the future we can cleanup those values. |
Yeah I always do the helm changes in a second PR. I will add the documentation there when I am doing it. |
Why What How was this tested tested extensivly locally and it works very well and leads to faster dev iteration cycles. Signed-off-by: murphp15 <[email protected]>
Why What How was this tested tested extensivly locally and it works very well and leads to faster dev iteration cycles. Signed-off-by: murphp15 <[email protected]>
Signed-off-by: murphp15 <[email protected]>
Signed-off-by: murphp15 <[email protected]>
...cts/pipelines_control_service/src/main/java/com/vmware/taurus/service/KubernetesService.java
Show resolved
Hide resolved
murphp15
deleted the
person/murphp15/builder-images-load-secrets-from-k8s
branch
Why
I wrote this PR with the intent of being able to pass extra docker creds to to the image builder so that we would be able to pull a private base image from a docker repo.
The builder now contains login details for 2 registries. The registry it pushes to and the registry it pulls base image from.
However this PR also introduces the concept of builder secrets being sourced from k8s which leads to much cleaner separation between the control plane and the builder image. I think this will lead to much better support for custom build images in the future.
I'm not sure where to add the documentation about the
builder-secrets. So I created a ticket to follow up on this later.#1357
How was this been tested
tested extensively locally.
I added a test to check that the base image can be pulled from a private repo but in fact it is pulling from the same repo as it is pushing to and so it is could let bugs through related to the auth not working for the base image repo.
closes #1333