From dd83413919fd86155501c4212ee87aea1cd92474 Mon Sep 17 00:00:00 2001 From: murphp15 Date: Fri, 25 Nov 2022 13:57:22 +0000 Subject: [PATCH 1/2] vdk-control-service: namespace can be null. Signed-off-by: murphp15 --- .../control-service/cicd/deploy-testing-pipelines-service.sh | 2 +- .../main/java/com/vmware/taurus/service/KubernetesService.java | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/projects/control-service/cicd/deploy-testing-pipelines-service.sh b/projects/control-service/cicd/deploy-testing-pipelines-service.sh index b14fd3de0d..910ac2f123 100755 --- a/projects/control-service/cicd/deploy-testing-pipelines-service.sh +++ b/projects/control-service/cicd/deploy-testing-pipelines-service.sh @@ -73,7 +73,7 @@ helm dependency update --kubeconfig=$KUBECONFIG # # image.tag is fixed during release. It is set here to deploy using latest change in source code. # We are using here embedded database, and we need to set the storageclass since in our test k8s no default storage class is not set. -helm upgrade --install --wait --timeout 10m0s $RELEASE_NAME . \ +helm upgrade --install --debug --wait --timeout 10m0s $RELEASE_NAME . \ --set image.tag="$TAG" \ --set resources.limits.memory=2G \ --set credentials.repository="EMPTY" \ diff --git a/projects/control-service/projects/pipelines_control_service/src/main/java/com/vmware/taurus/service/KubernetesService.java b/projects/control-service/projects/pipelines_control_service/src/main/java/com/vmware/taurus/service/KubernetesService.java index 556e78e455..5b88c1ac6e 100644 --- a/projects/control-service/projects/pipelines_control_service/src/main/java/com/vmware/taurus/service/KubernetesService.java +++ b/projects/control-service/projects/pipelines_control_service/src/main/java/com/vmware/taurus/service/KubernetesService.java @@ -199,7 +199,6 @@ private enum ContainerResourceType { */ protected KubernetesService( String namespace, String kubeconfig, boolean k8sSupportsV1CronJob, Logger log) { - assertTrue(StringUtils.isNotBlank(namespace), () -> "Namespace must be set to an actual value"); this.namespace = namespace; this.kubeconfig = kubeconfig; this.k8sSupportsV1CronJob = k8sSupportsV1CronJob; From f1f2945ce88453544e68fbdb602a6fdb82f5f887 Mon Sep 17 00:00:00 2001 From: github-actions <> Date: Fri, 25 Nov 2022 13:57:52 +0000 Subject: [PATCH 2/2] Google Java Format --- .../main/java/com/vmware/taurus/service/KubernetesService.java | 1 - 1 file changed, 1 deletion(-) diff --git a/projects/control-service/projects/pipelines_control_service/src/main/java/com/vmware/taurus/service/KubernetesService.java b/projects/control-service/projects/pipelines_control_service/src/main/java/com/vmware/taurus/service/KubernetesService.java index 5b88c1ac6e..e413be8adf 100644 --- a/projects/control-service/projects/pipelines_control_service/src/main/java/com/vmware/taurus/service/KubernetesService.java +++ b/projects/control-service/projects/pipelines_control_service/src/main/java/com/vmware/taurus/service/KubernetesService.java @@ -60,7 +60,6 @@ import java.util.function.Consumer; import java.util.stream.Collectors; -import static graphql.Assert.assertTrue; import static java.util.function.Predicate.not; /**