control-service: namespace can be null #1349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: murphp15 <[email protected]>
murphp15
changed the title
sabadzhiev
approved these changes
Nov 25, 2022
mivanov1988
approved these changes
Nov 25, 2022
antoniivanov
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Within my previous commit I wanted to cleanup the tests where we create namespaces on the fly if namespace is null or empty.
That code still did need to be removed and more of my PR was correct however when namespace is empty or null then we should take the default namespace from the kubeconfig file instead of throwing an error.
What
remove the assertion and add in debug logging to helm chart deployment to make this easier to debug.
How has this been tested
all pipelines.