Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jupyter-vep: Expand details on extensions design #1304
jupyter-vep: Expand details on extensions design #1304
Changes from all commits
edc92ab
86b6f28
983d713
c6acf36
0f6ef66
3170aed
75931d3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed saying that since it can be done at follow-up PR when you have better idea about these things
But we need to be very explicit here.
What are the exact graphical elements that would be introduced. Having mockup picture would be a huge bonus .
What are the exact request that would be sent and what commands would be supported?
Also there's a lot of assumption about what the reader knows and not everyone reading this would know how VDK works and what is file step plugin and etc , so you need either describe or better link to existing documentation that explain concepts you are using.