Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdk-control-service: add support for allowlist in helm chart. #1283

Merged
merged 5 commits into from
Nov 3, 2022
Merged

vdk-control-service: add support for allowlist in helm chart. #1283

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
14cb340
vdk-control-service: add support for allowlist in helm chart.
murphp15 Nov 2, 2022
bb9973a
vdk-control-service: add support for allowlist in helm chart.
murphp15 Nov 2, 2022
8e4304c
Merge branch 'main' into person/murphp15/addSupportForAllowListInHelm
murphp15 Nov 2, 2022
f3a3c4a
Merge branch 'main' into person/murphp15/addSupportForAllowListInHelm
murphp15 Nov 3, 2022
5d07904
Merge branch 'main' into person/murphp15/addSupportForAllowListInHelm
murphp15 Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .../control-service/projects/helm_charts/pipelines-control-service/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,8 @@ spec:
value: "{{ .Values.monitoringSync.delayMillis }}"
- name: DEFAULT_MONITORING_INITIAL_DELAY_SYNC_INTERVAL
value: "{{ .Values.monitoringSync.initialDelayMillis }}"
- name: UPLOAD_VALIDATION_FILETYPES_ALLOWLIST
value: "{{ .Values.uploadValidationFileTypesAllowList }}"
{{- if .Values.datajobTemplate.enabled }}
- name: K8S_DATA_JOB_TEMPLATE_FILE
value: "/etc/datajobs/k8s_data_job_template.yaml"
Expand Down Expand Up @@ -232,6 +234,7 @@ spec:
- name: DATAJOBS_DEPLOYMENT_BUILDER_SERVICE_ACCOUNT_NAME
value: "{{ .Values.deploymentBuilder.serviceAccountName }}"
{{- end }}

{{- if .Values.extraVars }}
{{ toYaml .Values.extraVars | indent 12 }}
{{- end }}
Expand Down
2 changes: 1 addition & 1 deletion projects/control-service/projects/helm_charts/pipelines-control-service/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ deploymentGitPassword: ""
# Credentials with read and write access to the Git repository.
uploadGitReadWriteUsername: ""
uploadGitReadWritePassword: ""

uploadValidationFileTypesAllowList: ""

## [Required] The repository where the data job images will be stored (so write permission must be granted)
## Automatically a repository will be created for each data job in ${deploymentDockerRepository}/data-job-name
Expand Down