-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vdk-control-service: add support for allowlist in helm chart. #1283
Conversation
Signed-off-by: murphp15 <[email protected]>
projects/control-service/projects/helm_charts/pipelines-control-service/values.yaml
Show resolved
Hide resolved
Testing Done: I think
Which helm repo? If it's one we push production releases charts. Please don't. If it's another, then ignore my comment. |
@tozka |
Ok. It's still safer to use your own repo (e.g the easiest one for you github account there's packages). |
Why?
We want to be able to configure the file scanning from the helm chart as described here: TAUR-5633
What?
Update the helm chart to support the property
How has this been tested?
I created a helm chart locally called
pipelines-control-service-prerelease
and pushed it to the remote helm repo.I then installed in the vdk aas env.
After I changed the values.yaml files in the vdk aas repo to make sure the property propagated as expected.
this is the PR where I test: it https://gitlab.eng.vmware.com/taurus/vdk/vdkaas-cicd/-/merge_requests/17
What type of change are you making?
New feature (non-breaking change which adds functionality)
Signed-off-by: murphp15 [email protected]