Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdk-control-service: add support for allowlist in helm chart. #1283

Merged
merged 5 commits into from
Nov 3, 2022

Conversation

murphp15
Copy link
Collaborator

@murphp15 murphp15 commented Nov 2, 2022

Why?

We want to be able to configure the file scanning from the helm chart as described here: TAUR-5633

What?

Update the helm chart to support the property

How has this been tested?

I created a helm chart locally called pipelines-control-service-prerelease and pushed it to the remote helm repo.
I then installed in the vdk aas env.
After I changed the values.yaml files in the vdk aas repo to make sure the property propagated as expected.
this is the PR where I test: it https://gitlab.eng.vmware.com/taurus/vdk/vdkaas-cicd/-/merge_requests/17

What type of change are you making?

New feature (non-breaking change which adds functionality)

Signed-off-by: murphp15 [email protected]

@antoniivanov
Copy link
Collaborator

antoniivanov commented Nov 2, 2022

Testing Done: I think helm template --debug or helm install --dry-run and verify the pasting here the resulting deployment would have been enough. Though of course your test is much more thorough.

pipelines-control-service-prerelease and pushed it to the remote helm repo.

Which helm repo? If it's one we push production releases charts. Please don't.
Any repo (be it pip, helm, docker) that we use for release should be updated only by our CICD.

If it's another, then ignore my comment.

@murphp15
Copy link
Collaborator Author

murphp15 commented Nov 2, 2022

@tozka
Its the same repo.
But I pushed it under the name pipelines-control-service-prerelease so there is no concern of someone picking it up by accident

@murphp15 murphp15 enabled auto-merge (squash) November 3, 2022 10:21
@antoniivanov
Copy link
Collaborator

@tozka Its the same repo. But I pushed it under the name pipelines-control-service-prerelease so there is no concern of someone picking it up by accident

Ok. It's still safer to use your own repo (e.g the easiest one for you github account there's packages).

@murphp15 murphp15 merged commit 5322a5a into main Nov 3, 2022
@murphp15 murphp15 deleted the person/murphp15/addSupportForAllowListInHelm branch November 3, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants